You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by xu...@apache.org on 2023/10/23 03:53:36 UTC

[incubator-opendal] branch main updated: refactor(service/mysql): Migrate to new task planner (#3357)

This is an automated email from the ASF dual-hosted git repository.

xuanwo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-opendal.git


The following commit(s) were added to refs/heads/main by this push:
     new 44fb3cc2b refactor(service/mysql): Migrate to new task planner (#3357)
44fb3cc2b is described below

commit 44fb3cc2b7529d22338a66756038e863adee8c95
Author: Nadeshiko Manju <me...@manjusaka.me>
AuthorDate: Mon Oct 23 11:53:31 2023 +0800

    refactor(service/mysql): Migrate to new task planner (#3357)
    
    * refactor(service/mysql) Migrate to new task planner
    
    Signed-off-by: Manjusaka <me...@manjusaka.me>
    
    * Update code
    
    Signed-off-by: Manjusaka <me...@manjusaka.me>
    
    ---------
    
    Signed-off-by: Manjusaka <me...@manjusaka.me>
---
 .github/services/mysql/mysql/action.yml  | 36 ++++++++++++++++++
 .github/workflows/service_test_mysql.yml | 65 --------------------------------
 bindings/java/Cargo.toml                 |  2 +
 3 files changed, 38 insertions(+), 65 deletions(-)

diff --git a/.github/services/mysql/mysql/action.yml b/.github/services/mysql/mysql/action.yml
new file mode 100644
index 000000000..4843cacbf
--- /dev/null
+++ b/.github/services/mysql/mysql/action.yml
@@ -0,0 +1,36 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: mysql
+description: 'Behavior test for mysql'
+
+runs:
+    using: "composite"
+    steps:
+        -   name: Setup MySQL Server
+            shell: bash
+            working-directory: fixtures/mysql
+            run: docker-compose -f docker-compose.yml up -d
+        - name: Setup
+          shell: bash
+          run: |
+              cat << EOF >> $GITHUB_ENV
+              OPENDAL_MYSQL_CONNECTION_STRING=mysql://root:password@localhost:3306/testdb
+              OPENDAL_MYSQL_TABLE=data
+              OPENDAL_MYSQL_KEY_FIELD=key
+              OPENDAL_MYSQL_VALUE_FIELD=data
+              EOF
diff --git a/.github/workflows/service_test_mysql.yml b/.github/workflows/service_test_mysql.yml
deleted file mode 100644
index a57ba8296..000000000
--- a/.github/workflows/service_test_mysql.yml
+++ /dev/null
@@ -1,65 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements.  See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership.  The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License.  You may obtain a copy of the License at
-#
-#   http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied.  See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-name: Service Test Mysql
-
-on:
-  push:
-    branches:
-      - main
-  pull_request:
-    branches:
-      - main
-    paths:
-      - "core/src/**"
-      - "core/tests/**"
-      - "!core/src/docs/**"
-      - "!core/src/services/**"
-      - "core/src/services/mysql/**"
-      - ".github/workflows/service_test_mysql.yml"
-      - "fixtures/mysql/**"
-
-concurrency:
-  group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
-  cancel-in-progress: true
-
-jobs:
-  mysql:
-    runs-on: ubuntu-latest
-
-    steps:
-      - uses: actions/checkout@v4
-      - name: Setup Mysql Server
-        shell: bash
-        working-directory: fixtures/mysql
-        run: docker-compose -f docker-compose.yml up -d
-
-      - name: Setup Rust toolchain
-        uses: ./.github/actions/setup
-        with:
-          need-nextest: true
-
-      - name: Test
-        shell: bash
-        working-directory: core
-        run: cargo nextest run behavior --features services-mysql
-        env:
-          OPENDAL_TEST: mysql
-          OPENDAL_MYSQL_CONNECTION_STRING: mysql://root:password@localhost:3306/testdb
-          OPENDAL_MYSQL_TABLE: data
-          OPENDAL_MYSQL_KEY_FIELD: key
-          OPENDAL_MYSQL_VALUE_FIELD: data
diff --git a/bindings/java/Cargo.toml b/bindings/java/Cargo.toml
index 09364f268..2ebb61910 100644
--- a/bindings/java/Cargo.toml
+++ b/bindings/java/Cargo.toml
@@ -70,6 +70,7 @@ services-all = [
   "services-onedrive",
   "services-persy",
   "services-postgresql",
+  "services-mysql",
   "services-redb",
   "services-redis",
   "services-redis-rustls",
@@ -123,6 +124,7 @@ services-supabase = ["opendal/services-supabase"]
 services-tikv = ["opendal/services-tikv"]
 services-vercel-artifacts = ["opendal/services-vercel-artifacts"]
 services-wasabi = ["opendal/services-wasabi"]
+services-mysql = ["opendal/services-mysql"]
 
 [dependencies]
 anyhow = "1.0.71"