You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Mark Chu-Carroll <mc...@twopensource.com> on 2014/10/08 19:32:15 UTC
Review Request 26448: Move the error-log seed file to a user specified
directory.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26448/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin and Zameer Manji.
Bugs: aurora-779
https://issues.apache.org/jira/browse/aurora-779
Repository: aurora
Description
-------
Instead of dumping error traces into the users current directory,
dump them into a user specified directory, with a benign default.
Diffs
-----
src/main/python/apache/aurora/client/cli/__init__.py 5c0688f5ea184e2c0b1f8e1b54a109d8260a12fa
src/main/python/apache/aurora/client/cli/standalone_client.py 4fdcf6df493f63aae672e0834214dad208cf4110
src/test/python/apache/aurora/client/cli/test_create.py 8dc0ccb78539f8b0c7829ec2927da93d4afa9ada
src/test/python/apache/aurora/client/cli/test_inspect.py fd35fe0185c1850910bd18d6a1e5831cd3effa6f
src/test/python/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a
src/test/python/apache/aurora/client/cli/util.py ff7eda20dbba073c8b24fbe3f4389292aab2d128
Diff: https://reviews.apache.org/r/26448/diff/
Testing
-------
Added new unit test; verified all tests pass.
Thanks,
Mark Chu-Carroll
Re: Review Request 26448: Move the error-log seed file to a user
specified directory.
Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26448/#review55838
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Oct. 8, 2014, 10:32 a.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26448/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2014, 10:32 a.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: aurora-779
> https://issues.apache.org/jira/browse/aurora-779
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Instead of dumping error traces into the users current directory,
> dump them into a user specified directory, with a benign default.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/__init__.py 5c0688f5ea184e2c0b1f8e1b54a109d8260a12fa
> src/main/python/apache/aurora/client/cli/standalone_client.py 4fdcf6df493f63aae672e0834214dad208cf4110
> src/test/python/apache/aurora/client/cli/test_create.py 8dc0ccb78539f8b0c7829ec2927da93d4afa9ada
> src/test/python/apache/aurora/client/cli/test_inspect.py fd35fe0185c1850910bd18d6a1e5831cd3effa6f
> src/test/python/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a
> src/test/python/apache/aurora/client/cli/util.py ff7eda20dbba073c8b24fbe3f4389292aab2d128
>
> Diff: https://reviews.apache.org/r/26448/diff/
>
>
> Testing
> -------
>
> Added new unit test; verified all tests pass.
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 26448: Move the error-log seed file to a user
specified directory.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26448/#review55837
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On Oct. 8, 2014, 5:32 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26448/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2014, 5:32 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: aurora-779
> https://issues.apache.org/jira/browse/aurora-779
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Instead of dumping error traces into the users current directory,
> dump them into a user specified directory, with a benign default.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/__init__.py 5c0688f5ea184e2c0b1f8e1b54a109d8260a12fa
> src/main/python/apache/aurora/client/cli/standalone_client.py 4fdcf6df493f63aae672e0834214dad208cf4110
> src/test/python/apache/aurora/client/cli/test_create.py 8dc0ccb78539f8b0c7829ec2927da93d4afa9ada
> src/test/python/apache/aurora/client/cli/test_inspect.py fd35fe0185c1850910bd18d6a1e5831cd3effa6f
> src/test/python/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a
> src/test/python/apache/aurora/client/cli/util.py ff7eda20dbba073c8b24fbe3f4389292aab2d128
>
> Diff: https://reviews.apache.org/r/26448/diff/
>
>
> Testing
> -------
>
> Added new unit test; verified all tests pass.
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>