[GitHub] craigappl commented on issue #3972: [feature] Global customise-able d3 locale

[GitBox <gi...@apache.org>]

craigappl commented on issue #3972: [feature] Global customise-able d3 locale
URL: https://github.com/apache/incubator-superset/issues/3972#issuecomment-447307711
 
 
   I think the bigger issue here would be to align locales in Superset and D3. D3 already supports localized number and time formats.
   
   There seems to be an alignment issue between Superset and D3 locales. For example, Brazilian Portuguese in Superset is PT_BR and the D3 pt-BR. I think the most robust solution would be to have each chart call the D3 locale based on the user's Superset locale when the chart is displayed. You can see in the sources below that D3 already has everything we need, we just aren't applying it to the user's selected locale.
   
   FYI @mistercrunch and @csc5k
   
   Sources:
   Superset Translations: https://github.com/apache/incubator-superset/tree/master/superset/translations
   D3-Format: https://github.com/d3/d3-format/blob/master/locale/pt-BR.json
   D3-Time-Format: https://github.com/d3/d3-time-format/blob/master/locale/pt-BR.json

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org