[jira] [Commented] (FLINK-14367) Fully support for converting RexNode to Expression

["Timo Walther (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-14367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949316#comment-16949316 ] 

Timo Walther commented on FLINK-14367:
--------------------------------------

FLIP-51 should simplify the implementation of RexNodeToExpressionConverter.

> Fully support for converting RexNode to Expression
> --------------------------------------------------
>
>                 Key: FLINK-14367
>                 URL: https://issues.apache.org/jira/browse/FLINK-14367
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / Planner
>            Reporter: Jark Wu
>            Priority: Major
>
> Currently, the {{RexNodeToExpressionConverter}} in both planners are not fully support. There're many RexNodes can not be converted to Expressions.
> 1) RexFieldAccess -> GET call
> 2) Literals in interval types and complex types
> 3) TRIM(BOTH/LEADING/HEADING, ..) 
> ...
> We should have a comprehensive tests to cover all cases. A good idea is to verify with {{ExpressionConverter}} together. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)