You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by pvillard31 <gi...@git.apache.org> on 2018/02/02 09:18:52 UTC

[GitHub] nifi pull request #2440: NIFI-4826 Fixed azure.blobname in ListAzureBlobStor...

Github user pvillard31 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2440#discussion_r165593121
  
    --- Diff: nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/ListAzureBlobStorage.java ---
    @@ -106,7 +106,8 @@
             attributes.put("azure.etag", entity.getEtag());
             attributes.put("azure.primaryUri", entity.getPrimaryUri());
             attributes.put("azure.secondaryUri", entity.getSecondaryUri());
    -        attributes.put("azure.blobname", entity.getName());
    +        attributes.put("azure.blobname", entity.getBlobName());
    +        attributes.put("filename", entity.getName());
    --- End diff --
    
    I'm a bit worried about this change. It's going to change the value of a core attribute (filename) that could break the behavior of existing workflows. I'd rather user another attribute name if we still want to have an attribute for ``entity.getName()``. Thoughts?


---