You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2025/09/23 18:57:13 UTC
[PR] updates expected error message in resource group shell IT [accumulo]
keith-turner opened a new pull request, #5925:
URL: https://github.com/apache/accumulo/pull/5925
An error message changed in #5893 and the test needs to check for the new error message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] updates expected error message in resource group shell IT [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner merged PR #5925:
URL: https://github.com/apache/accumulo/pull/5925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] updates expected error message in resource group shell IT [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #5925:
URL: https://github.com/apache/accumulo/pull/5925#discussion_r2373366044
##########
test/src/main/java/org/apache/accumulo/test/shell/ShellServerIT.java:
##########
@@ -2490,7 +2490,7 @@ public void resourceGroups() throws AccumuloException, AccumuloSecurityException
assertEquals(1, ops.list().size());
assertEquals(ResourceGroupId.DEFAULT, ops.list().iterator().next());
- ts.exec("createresourcegroup " + badRG, false, "contains invalid characters");
+ ts.exec("createresourcegroup " + badRG, false, "Group name 'test-RG' is invalid");
Review Comment:
> Is there a reason to hard code the group name vs just use the variable?
No that would be good, I just copied and pasted the error in the failed test output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] updates expected error message in resource group shell IT [accumulo]
Posted by "ddanielr (via GitHub)" <gi...@apache.org>.
ddanielr commented on code in PR #5925:
URL: https://github.com/apache/accumulo/pull/5925#discussion_r2373345481
##########
test/src/main/java/org/apache/accumulo/test/shell/ShellServerIT.java:
##########
@@ -2490,7 +2490,7 @@ public void resourceGroups() throws AccumuloException, AccumuloSecurityException
assertEquals(1, ops.list().size());
assertEquals(ResourceGroupId.DEFAULT, ops.list().iterator().next());
- ts.exec("createresourcegroup " + badRG, false, "contains invalid characters");
+ ts.exec("createresourcegroup " + badRG, false, "Group name 'test-RG' is invalid");
Review Comment:
Is there a reason to hard code the group name vs just use the variable?
```suggestion
ts.exec("createresourcegroup " + badRG, false, "Group name '" + badRG +"' is invalid");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org