You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/06/30 12:09:56 UTC
[GitHub] [calcite] zstan opened a new pull request #2448: [CALCITE-4673] Correlate variables deduplication are not triggers under COLLECTION_TABLE condition.
zstan opened a new pull request #2448:
URL: https://github.com/apache/calcite/pull/2448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] zabetak commented on pull request #2448: [CALCITE-4673] Correlate variables deduplication is not triggered when custom table function presented.
Posted by GitBox <gi...@apache.org>.
zabetak commented on pull request #2448:
URL: https://github.com/apache/calcite/pull/2448#issuecomment-894127536
> @julianhyde @zabetak Checker failed with no additional info, plz help with it ? locally tests are ok.
@zstan I restarted the jobs to see if it passes but in general you can run the CheckerFramework verifications locally by passing the `-PenableCheckerframework` option.
`./gradlew -PenableCheckerframework :linq4j:classes :core:classes `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] zinking commented on pull request #2448: [CALCITE-4673] Correlate variables deduplication is not triggered when custom table function presented.
Posted by GitBox <gi...@apache.org>.
zinking commented on pull request #2448:
URL: https://github.com/apache/calcite/pull/2448#issuecomment-876125804
looks good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] julianhyde commented on pull request #2448: [CALCITE-4673] Correlate variables deduplication is not triggered when custom table function presented.
Posted by GitBox <gi...@apache.org>.
julianhyde commented on pull request #2448:
URL: https://github.com/apache/calcite/pull/2448#issuecomment-894374289
I'm doing final review. I made some cosmetic changes in https://github.com/julianhyde/calcite/tree/4673-correlated-table and am testing now. Will merge shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] zinking commented on a change in pull request #2448: [CALCITE-4673] Correlate variables deduplication is not triggered when custom table function presented.
Posted by GitBox <gi...@apache.org>.
zinking commented on a change in pull request #2448:
URL: https://github.com/apache/calcite/pull/2448#discussion_r665868748
##########
File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java
##########
@@ -1255,11 +1255,11 @@ private void substituteSubQuery(Blackboard bb, SubQuery subQuery) {
//
// If there is no correlation, the expression is replaced with a
// boolean indicating whether the sub-query returned 0 or >= 1 row.
- call = (SqlBasicCall) subQuery.node;
- query = call.operand(0);
if (!config.isExpand()) {
return;
}
+ call = (SqlBasicCall) subQuery.node;
Review comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] zstan commented on pull request #2448: [CALCITE-4673] Correlate variables deduplication is not triggered when custom table function presented.
Posted by GitBox <gi...@apache.org>.
zstan commented on pull request #2448:
URL: https://github.com/apache/calcite/pull/2448#issuecomment-894031801
@julianhyde @zabetak Checker failed with no additional info, plz help with it ? locally tests are ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] julianhyde closed pull request #2448: [CALCITE-4673] Correlate variables deduplication is not triggered when custom table function presented.
Posted by GitBox <gi...@apache.org>.
julianhyde closed pull request #2448:
URL: https://github.com/apache/calcite/pull/2448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org