You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "itholic (via GitHub)" <gi...@apache.org> on 2023/06/14 04:38:12 UTC

[GitHub] [spark] itholic commented on a diff in pull request #41587: [SPARK-43654][SPARK-43655] Ensure that Spark Connect assigns correct column name

itholic commented on code in PR #41587:
URL: https://github.com/apache/spark/pull/41587#discussion_r1228974342


##########
python/pyspark/pandas/utils.py:
##########
@@ -964,7 +964,7 @@ def spark_column_equals(left: Column, right: Column) -> bool:
                 error_class="NOT_COLUMN",
                 message_parameters={"arg_name": "right", "arg_type": type(right).__name__},
             )
-        return repr(left) == repr(right)
+        return left._expr == right._expr

Review Comment:
   This is also fixed to compare the column name properly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org