You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2016/11/04 16:32:08 UTC
[GitHub] brooklyn-server pull request #404: Fix Transformer (for when registered befo...
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/404
Fix Transformer (for when registered before entity managed)
The transformer can be added before the entity is managed (e.g. if
specified in the entity spec, as is often done via yaml). In that case,
the entity\u2019s management context is still a `NonDeploymentManagementContext`.
The subscriptions are stored in a queue. When the entity is managed,
the subscriptions are replayed.
However, the queued subscriptions did not store the entity context.
Therefore when the transformer received its events, it didn\u2019t have
an entity context so could not determine which entity it was talking
about.
This caused brooklyn-library\u2019s `EnrichersSlightlySimplerYamlTest.testWithAppEnricher`
to fail.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server fix-EnrichersSlightlySimplerYamlTest
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/404.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #404
----
commit e583d3ae6a757ba27e1d249cd1946dfdfaf5e441
Author: Aled Sage <al...@gmail.com>
Date: 2016-11-04T16:31:16Z
Fix Transformer (for when registered before entity managed)
The transformer can be added before the entity is managed (e.g. if
specified in the entity spec, as is often done via yaml). In that case,
the entity\u2019s management context is still a \u201cNonDeploymentManagementContext\u201d.
The subscriptions are stored in a queue. When the entity is managed,
the subscriptions are replayed.
However, the queued subscriptions did not store the entity context.
Therefore when the transformer received its events, it didn\u2019t have
an entity context so could not determine which entity it was talking
about.
This caused brooklyn-library\u2019s EnrichersSlightlySimplerYamlTest.testWithAppEnricher
to fail.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #404: Fix Transformer (for when registered befo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/404
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #404: Fix Transformer (for when registered before enti...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/404
Makes sense, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---