You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/12/19 19:28:14 UTC
[GitHub] [superset] singhrajk opened a new issue, #22459: Does this strip_comments have to be True by default?
singhrajk opened a new issue, #22459:
URL: https://github.com/apache/superset/issues/22459
https://github.com/apache/superset/blob/858796b98fdeb55f21d913c59d42c36507601eb5/superset/sql_lab.py#L416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on issue #22459: Does this strip_comments have to be True by default?
Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #22459:
URL: https://github.com/apache/superset/issues/22459#issuecomment-1371505337
Closing this since it's not a bug, per se, but I believe the answer is "yes" this is considered to be the sensible default.
If you feel that should not be the case, let us know here, or we can it that up in a [Discussion](https://github.com/apache/superset/discussions) or on [Slack](https://join.slack.com/t/apache-superset/shared_invite/zt-1jp6hjzrq-H0PlFtToyLWuPiJDuRWCNw).
I'll also CC @betodealmeida here for good measure, since they wrote the line in question.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on issue #22459: Does this strip_comments have to be True by default?
Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #22459:
URL: https://github.com/apache/superset/issues/22459#issuecomment-1381045745
Apologies. Those links expire frequently. We're going to try keeping this link current from here on out:
http://bit.ly/join-superset-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] singhrajk commented on issue #22459: Does this strip_comments have to be True by default?
Posted by GitBox <gi...@apache.org>.
singhrajk commented on issue #22459:
URL: https://github.com/apache/superset/issues/22459#issuecomment-1380193672
The link to join slack community is not working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas closed issue #22459: Does this strip_comments have to be True by default?
Posted by GitBox <gi...@apache.org>.
rusackas closed issue #22459: Does this strip_comments have to be True by default?
URL: https://github.com/apache/superset/issues/22459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org