You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "SamBarker (via GitHub)" <gi...@apache.org> on 2024/10/10 06:57:15 UTC

[PR] [FLINK-36460] Refactoring the CI matrix [flink-kubernetes-operator]

SamBarker opened a new pull request, #893:
URL: https://github.com/apache/flink-kubernetes-operator/pull/893

   ## What is the purpose of the change
   
   As observed in [FLINK-36332](https://github.com/apache/flink-kubernetes-operator/pull/881#issuecomment-2378765602) the CI workflow has become difficult to mange. This PR is attempting to split tests along sensible lines to make the matrix more manageable. 
   
   ## Brief change log
   
   Simplify CI workflows.
   
   ## Verifying this change
   
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changes to the `CustomResourceDescriptors`: **no**
     - Core observer or reconciler logic that is regularly executed: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **not applicable**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-36460] Refactoring the CI matrix [flink-kubernetes-operator]

Posted by "gyfora (via GitHub)" <gi...@apache.org>.
gyfora merged PR #893:
URL: https://github.com/apache/flink-kubernetes-operator/pull/893


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-36460] Refactoring the CI matrix [flink-kubernetes-operator]

Posted by "SamBarker (via GitHub)" <gi...@apache.org>.
SamBarker commented on PR #893:
URL: https://github.com/apache/flink-kubernetes-operator/pull/893#issuecomment-2450957960

   I think I've finally got the excludes to align with main. *sigh* That was a lot more fuss than I wanted and doesn't end up as clean as I was hoping. However I think this represents a much cleaner way to setup test matrices. 
   
   The tests are still very slow to run as each test has to build its own copies of the containers. I think thats resolvable without publishing temporary artefacts to a container registry. Some combination of [docker advice](https://docs.docker.com/build/ci/github-actions/share-image-jobs/) and GitHub [sharing data docs](https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/storing-and-sharing-data-from-a-workflow) along with this [discussion](https://github.com/docker/build-push-action/issues/225). 
   
   That feels like a separate PR.
   
   @gyfora could you trigger another run of the PR please (its gone green on my fork) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-36460] Refactoring the CI matrix [flink-kubernetes-operator]

Posted by "SamBarker (via GitHub)" <gi...@apache.org>.
SamBarker commented on PR #893:
URL: https://github.com/apache/flink-kubernetes-operator/pull/893#issuecomment-2437141425

   This shows it in action on my fork: ![Screenshot 2024-10-25 at 8 58 16 pm](https://github.com/user-attachments/assets/6e69c7b2-eaea-4b35-abe5-c898d02b2461)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-36460] Refactoring the CI matrix [flink-kubernetes-operator]

Posted by "SamBarker (via GitHub)" <gi...@apache.org>.
SamBarker commented on PR #893:
URL: https://github.com/apache/flink-kubernetes-operator/pull/893#issuecomment-2437138461

   @gyfora alternative CI matrix as requested. Even if the matrix proposed in this PR doesn't feel "right" it sets things up so that the matrix is considerably easier to change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org