[GitHub] [tvm] masahi commented on a change in pull request #8165: [Relay, TOPI] Refactor strided_slice and add axes argument

[GitBox <gi...@apache.org>]

masahi commented on a change in pull request #8165:
URL: https://github.com/apache/tvm/pull/8165#discussion_r643593227



##########
File path: python/tvm/relay/op/transform.py
##########
@@ -917,7 +922,7 @@ def strided_slice(data, begin, end, strides=None, slice_mode="end"):
         begin = _make.where(begin < cast_like(const(0), begin), begin + ishape_slice, begin)
         begin = _make.where(begin >= ishape_slice, ishape_slice, begin)
         return _dyn_make.strided_slice(data, begin, end, strides, slice_mode)

Review comment:
       Yeah I haven't put much thought into `axes` argument for dynamic strided slice. My goal was to preserve more static dimensions along `axes`, which doesn't apply to the dynamic parameter variant. We should support it for convenience and API consistency sake, but for now I'd like to leave it as TODO and assert `axes is None` here until someone complains or comes up with a good use case.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org