You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Joe Bowser <bo...@gmail.com> on 2013/09/17 22:27:10 UTC
[Android] InAppBrowser re-write/update
Hey
It's come to my attention that InAppBrowser is terrible
1. We keep getting UI Thread errors
2. The UI is awful (on Android)
3. We can now move drawables in plugins
So, I propose that we do a re-write of InAppBrowser and add the
ability to move drawable resources to plugman. Even though I think
that InAppBrowser sucks and that we should have plugins to use
different accounts on the device instead of Web OAuth, we're stuck
with this until someone gets around to actually doing it.
So, Are people cool with this plugin getting re-worked?
Joe
Re: [Android] InAppBrowser re-write/update
Posted by Max Woghiren <ma...@chromium.org>.
Just to clarify, Michal meant that the Chrome identity plugin has been
getting a lot of effort from me. :)
I have been working on InAppBrowser plugin tangentially to get some Chrome
identity stuff working, but not enough to be completely familiar with its
innards. However, I'm certainly happy to work with you to fix InAppBrowser.
I'll familiarize myself more with the plugin and get back to you. In the
meantime, if you have more detailed ideas, send away!
On Tue, Sep 17, 2013 at 5:13 PM, Joe Bowser <bo...@gmail.com> wrote:
> Max, should I redirect all InAppBrowser issues to you if you're already on
> it?
>
> Here's some thoughts:
> * I think that it needs to be broken out into multiple classes. The
> InAppWebView is becoming non-trivial, and probably should have its own
> class.
> * I can tweak the UI so that it's a bit better. I don't like the
> black background, and it should have a refresh button, not just a done
> button.
>
> That being said, we should encourage people to just use the browser
> intent on Android as much as possible. I know that on iOS that
> InAppBrowser makes sense, but there's a lot of cases where it really
> just should open Chrome and viewing it in our own thing just looks
> weird.
>
> On Tue, Sep 17, 2013 at 1:38 PM, Michal Mocny <mm...@chromium.org> wrote:
> > +Max who has been finding some issues with what we have and trying to fix
> > them one by one. I'de love to see some UI sprucing, and I can't speak
> > specifically to the drawables.
> >
> > You suggest that we use accounts on the device as a plugin, well our team
> > has done just that with the chrome.identity plugin which is available for
> > vanilla cordova apps:
> >
> https://github.com/MobileChromeApps/chrome-cordova/tree/master/plugins/chrome.identity
> >
> > That plugin specifically is getting a lot effort put into it from Max
> right
> > now, so if there are any limitations just bring them up.
> >
> > -Michal
> >
> >
> > On Tue, Sep 17, 2013 at 1:27 PM, Joe Bowser <bo...@gmail.com> wrote:
> >
> >> Hey
> >>
> >> It's come to my attention that InAppBrowser is terrible
> >>
> >> 1. We keep getting UI Thread errors
> >> 2. The UI is awful (on Android)
> >> 3. We can now move drawables in plugins
> >>
> >> So, I propose that we do a re-write of InAppBrowser and add the
> >> ability to move drawable resources to plugman. Even though I think
> >> that InAppBrowser sucks and that we should have plugins to use
> >> different accounts on the device instead of Web OAuth, we're stuck
> >> with this until someone gets around to actually doing it.
> >>
> >> So, Are people cool with this plugin getting re-worked?
> >>
> >> Joe
> >>
>
Re: [Android] InAppBrowser re-write/update
Posted by Joe Bowser <bo...@gmail.com>.
No. This has nothing to do with cradle and everything to do with us moving
source. Gradle is a different thread.
On Sep 17, 2013 6:22 PM, "Andrew Grieve" <ag...@chromium.org> wrote:
> Are you referring to Gradle's ability to merge assets / resources from
> dependent targets? Or has that ability now made its way into ADT / Ant? Or
> are you thinking of moving to Gradle?
>
> I think any IAB improvements are welcome.
>
>
> On Tue, Sep 17, 2013 at 6:54 PM, Joe Bowser <bo...@gmail.com> wrote:
>
> > Hey
> >
> > I just pushed up some minor changes that make a pretty big difference:
> >
> > 1. I made the background color of the nav bar grey. This already
> > makes a huge difference, although I would like to use icons instead of
> > characters, since this would make it a bit more polished. I'm
> > thinking of using Noun Project work, since the licence may be
> > compatible, although I'll have to look into this.
> > 2. I broke out the ChromeClient. The Web Client will have to stay
> > out, but now it's not one big monolithic file, and is easier to
> > tackle.
> >
> > It's on the dev branch of the InAppBrowser repository, BTW. I created
> > some issues in JIRA to correspond to the changes.
> >
> > On Tue, Sep 17, 2013 at 2:46 PM, David Kemp <dr...@chromium.org> wrote:
> > > Joe, I think Andrew put my name on one of the InAppBrowser issues
> > because
> > > I am just starting to look at some of the thread issues in that and
> > > plugins.
> > > But I am happy to share :)
> > > On Sep 17, 2013 5:14 PM, "Joe Bowser" <bo...@gmail.com> wrote:
> > >
> > >> Max, should I redirect all InAppBrowser issues to you if you're
> already
> > on
> > >> it?
> > >>
> > >> Here's some thoughts:
> > >> * I think that it needs to be broken out into multiple classes. The
> > >> InAppWebView is becoming non-trivial, and probably should have its own
> > >> class.
> > >> * I can tweak the UI so that it's a bit better. I don't like the
> > >> black background, and it should have a refresh button, not just a done
> > >> button.
> > >>
> > >> That being said, we should encourage people to just use the browser
> > >> intent on Android as much as possible. I know that on iOS that
> > >> InAppBrowser makes sense, but there's a lot of cases where it really
> > >> just should open Chrome and viewing it in our own thing just looks
> > >> weird.
> > >>
> > >> On Tue, Sep 17, 2013 at 1:38 PM, Michal Mocny <mm...@chromium.org>
> > wrote:
> > >> > +Max who has been finding some issues with what we have and trying
> to
> > fix
> > >> > them one by one. I'de love to see some UI sprucing, and I can't
> speak
> > >> > specifically to the drawables.
> > >> >
> > >> > You suggest that we use accounts on the device as a plugin, well our
> > team
> > >> > has done just that with the chrome.identity plugin which is
> available
> > for
> > >> > vanilla cordova apps:
> > >> >
> > >>
> >
> https://github.com/MobileChromeApps/chrome-cordova/tree/master/plugins/chrome.identity
> > >> >
> > >> > That plugin specifically is getting a lot effort put into it from
> Max
> > >> right
> > >> > now, so if there are any limitations just bring them up.
> > >> >
> > >> > -Michal
> > >> >
> > >> >
> > >> > On Tue, Sep 17, 2013 at 1:27 PM, Joe Bowser <bo...@gmail.com>
> > wrote:
> > >> >
> > >> >> Hey
> > >> >>
> > >> >> It's come to my attention that InAppBrowser is terrible
> > >> >>
> > >> >> 1. We keep getting UI Thread errors
> > >> >> 2. The UI is awful (on Android)
> > >> >> 3. We can now move drawables in plugins
> > >> >>
> > >> >> So, I propose that we do a re-write of InAppBrowser and add the
> > >> >> ability to move drawable resources to plugman. Even though I think
> > >> >> that InAppBrowser sucks and that we should have plugins to use
> > >> >> different accounts on the device instead of Web OAuth, we're stuck
> > >> >> with this until someone gets around to actually doing it.
> > >> >>
> > >> >> So, Are people cool with this plugin getting re-worked?
> > >> >>
> > >> >> Joe
> > >> >>
> > >>
> >
>
Re: [Android] InAppBrowser re-write/update
Posted by Andrew Grieve <ag...@chromium.org>.
Are you referring to Gradle's ability to merge assets / resources from
dependent targets? Or has that ability now made its way into ADT / Ant? Or
are you thinking of moving to Gradle?
I think any IAB improvements are welcome.
On Tue, Sep 17, 2013 at 6:54 PM, Joe Bowser <bo...@gmail.com> wrote:
> Hey
>
> I just pushed up some minor changes that make a pretty big difference:
>
> 1. I made the background color of the nav bar grey. This already
> makes a huge difference, although I would like to use icons instead of
> characters, since this would make it a bit more polished. I'm
> thinking of using Noun Project work, since the licence may be
> compatible, although I'll have to look into this.
> 2. I broke out the ChromeClient. The Web Client will have to stay
> out, but now it's not one big monolithic file, and is easier to
> tackle.
>
> It's on the dev branch of the InAppBrowser repository, BTW. I created
> some issues in JIRA to correspond to the changes.
>
> On Tue, Sep 17, 2013 at 2:46 PM, David Kemp <dr...@chromium.org> wrote:
> > Joe, I think Andrew put my name on one of the InAppBrowser issues
> because
> > I am just starting to look at some of the thread issues in that and
> > plugins.
> > But I am happy to share :)
> > On Sep 17, 2013 5:14 PM, "Joe Bowser" <bo...@gmail.com> wrote:
> >
> >> Max, should I redirect all InAppBrowser issues to you if you're already
> on
> >> it?
> >>
> >> Here's some thoughts:
> >> * I think that it needs to be broken out into multiple classes. The
> >> InAppWebView is becoming non-trivial, and probably should have its own
> >> class.
> >> * I can tweak the UI so that it's a bit better. I don't like the
> >> black background, and it should have a refresh button, not just a done
> >> button.
> >>
> >> That being said, we should encourage people to just use the browser
> >> intent on Android as much as possible. I know that on iOS that
> >> InAppBrowser makes sense, but there's a lot of cases where it really
> >> just should open Chrome and viewing it in our own thing just looks
> >> weird.
> >>
> >> On Tue, Sep 17, 2013 at 1:38 PM, Michal Mocny <mm...@chromium.org>
> wrote:
> >> > +Max who has been finding some issues with what we have and trying to
> fix
> >> > them one by one. I'de love to see some UI sprucing, and I can't speak
> >> > specifically to the drawables.
> >> >
> >> > You suggest that we use accounts on the device as a plugin, well our
> team
> >> > has done just that with the chrome.identity plugin which is available
> for
> >> > vanilla cordova apps:
> >> >
> >>
> https://github.com/MobileChromeApps/chrome-cordova/tree/master/plugins/chrome.identity
> >> >
> >> > That plugin specifically is getting a lot effort put into it from Max
> >> right
> >> > now, so if there are any limitations just bring them up.
> >> >
> >> > -Michal
> >> >
> >> >
> >> > On Tue, Sep 17, 2013 at 1:27 PM, Joe Bowser <bo...@gmail.com>
> wrote:
> >> >
> >> >> Hey
> >> >>
> >> >> It's come to my attention that InAppBrowser is terrible
> >> >>
> >> >> 1. We keep getting UI Thread errors
> >> >> 2. The UI is awful (on Android)
> >> >> 3. We can now move drawables in plugins
> >> >>
> >> >> So, I propose that we do a re-write of InAppBrowser and add the
> >> >> ability to move drawable resources to plugman. Even though I think
> >> >> that InAppBrowser sucks and that we should have plugins to use
> >> >> different accounts on the device instead of Web OAuth, we're stuck
> >> >> with this until someone gets around to actually doing it.
> >> >>
> >> >> So, Are people cool with this plugin getting re-worked?
> >> >>
> >> >> Joe
> >> >>
> >>
>
Re: [Android] InAppBrowser re-write/update
Posted by Joe Bowser <bo...@gmail.com>.
Hey
I just pushed up some minor changes that make a pretty big difference:
1. I made the background color of the nav bar grey. This already
makes a huge difference, although I would like to use icons instead of
characters, since this would make it a bit more polished. I'm
thinking of using Noun Project work, since the licence may be
compatible, although I'll have to look into this.
2. I broke out the ChromeClient. The Web Client will have to stay
out, but now it's not one big monolithic file, and is easier to
tackle.
It's on the dev branch of the InAppBrowser repository, BTW. I created
some issues in JIRA to correspond to the changes.
On Tue, Sep 17, 2013 at 2:46 PM, David Kemp <dr...@chromium.org> wrote:
> Joe, I think Andrew put my name on one of the InAppBrowser issues because
> I am just starting to look at some of the thread issues in that and
> plugins.
> But I am happy to share :)
> On Sep 17, 2013 5:14 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>
>> Max, should I redirect all InAppBrowser issues to you if you're already on
>> it?
>>
>> Here's some thoughts:
>> * I think that it needs to be broken out into multiple classes. The
>> InAppWebView is becoming non-trivial, and probably should have its own
>> class.
>> * I can tweak the UI so that it's a bit better. I don't like the
>> black background, and it should have a refresh button, not just a done
>> button.
>>
>> That being said, we should encourage people to just use the browser
>> intent on Android as much as possible. I know that on iOS that
>> InAppBrowser makes sense, but there's a lot of cases where it really
>> just should open Chrome and viewing it in our own thing just looks
>> weird.
>>
>> On Tue, Sep 17, 2013 at 1:38 PM, Michal Mocny <mm...@chromium.org> wrote:
>> > +Max who has been finding some issues with what we have and trying to fix
>> > them one by one. I'de love to see some UI sprucing, and I can't speak
>> > specifically to the drawables.
>> >
>> > You suggest that we use accounts on the device as a plugin, well our team
>> > has done just that with the chrome.identity plugin which is available for
>> > vanilla cordova apps:
>> >
>> https://github.com/MobileChromeApps/chrome-cordova/tree/master/plugins/chrome.identity
>> >
>> > That plugin specifically is getting a lot effort put into it from Max
>> right
>> > now, so if there are any limitations just bring them up.
>> >
>> > -Michal
>> >
>> >
>> > On Tue, Sep 17, 2013 at 1:27 PM, Joe Bowser <bo...@gmail.com> wrote:
>> >
>> >> Hey
>> >>
>> >> It's come to my attention that InAppBrowser is terrible
>> >>
>> >> 1. We keep getting UI Thread errors
>> >> 2. The UI is awful (on Android)
>> >> 3. We can now move drawables in plugins
>> >>
>> >> So, I propose that we do a re-write of InAppBrowser and add the
>> >> ability to move drawable resources to plugman. Even though I think
>> >> that InAppBrowser sucks and that we should have plugins to use
>> >> different accounts on the device instead of Web OAuth, we're stuck
>> >> with this until someone gets around to actually doing it.
>> >>
>> >> So, Are people cool with this plugin getting re-worked?
>> >>
>> >> Joe
>> >>
>>
Re: [Android] InAppBrowser re-write/update
Posted by David Kemp <dr...@chromium.org>.
Joe, I think Andrew put my name on one of the InAppBrowser issues because
I am just starting to look at some of the thread issues in that and
plugins.
But I am happy to share :)
On Sep 17, 2013 5:14 PM, "Joe Bowser" <bo...@gmail.com> wrote:
> Max, should I redirect all InAppBrowser issues to you if you're already on
> it?
>
> Here's some thoughts:
> * I think that it needs to be broken out into multiple classes. The
> InAppWebView is becoming non-trivial, and probably should have its own
> class.
> * I can tweak the UI so that it's a bit better. I don't like the
> black background, and it should have a refresh button, not just a done
> button.
>
> That being said, we should encourage people to just use the browser
> intent on Android as much as possible. I know that on iOS that
> InAppBrowser makes sense, but there's a lot of cases where it really
> just should open Chrome and viewing it in our own thing just looks
> weird.
>
> On Tue, Sep 17, 2013 at 1:38 PM, Michal Mocny <mm...@chromium.org> wrote:
> > +Max who has been finding some issues with what we have and trying to fix
> > them one by one. I'de love to see some UI sprucing, and I can't speak
> > specifically to the drawables.
> >
> > You suggest that we use accounts on the device as a plugin, well our team
> > has done just that with the chrome.identity plugin which is available for
> > vanilla cordova apps:
> >
> https://github.com/MobileChromeApps/chrome-cordova/tree/master/plugins/chrome.identity
> >
> > That plugin specifically is getting a lot effort put into it from Max
> right
> > now, so if there are any limitations just bring them up.
> >
> > -Michal
> >
> >
> > On Tue, Sep 17, 2013 at 1:27 PM, Joe Bowser <bo...@gmail.com> wrote:
> >
> >> Hey
> >>
> >> It's come to my attention that InAppBrowser is terrible
> >>
> >> 1. We keep getting UI Thread errors
> >> 2. The UI is awful (on Android)
> >> 3. We can now move drawables in plugins
> >>
> >> So, I propose that we do a re-write of InAppBrowser and add the
> >> ability to move drawable resources to plugman. Even though I think
> >> that InAppBrowser sucks and that we should have plugins to use
> >> different accounts on the device instead of Web OAuth, we're stuck
> >> with this until someone gets around to actually doing it.
> >>
> >> So, Are people cool with this plugin getting re-worked?
> >>
> >> Joe
> >>
>
Re: [Android] InAppBrowser re-write/update
Posted by Joe Bowser <bo...@gmail.com>.
Max, should I redirect all InAppBrowser issues to you if you're already on it?
Here's some thoughts:
* I think that it needs to be broken out into multiple classes. The
InAppWebView is becoming non-trivial, and probably should have its own
class.
* I can tweak the UI so that it's a bit better. I don't like the
black background, and it should have a refresh button, not just a done
button.
That being said, we should encourage people to just use the browser
intent on Android as much as possible. I know that on iOS that
InAppBrowser makes sense, but there's a lot of cases where it really
just should open Chrome and viewing it in our own thing just looks
weird.
On Tue, Sep 17, 2013 at 1:38 PM, Michal Mocny <mm...@chromium.org> wrote:
> +Max who has been finding some issues with what we have and trying to fix
> them one by one. I'de love to see some UI sprucing, and I can't speak
> specifically to the drawables.
>
> You suggest that we use accounts on the device as a plugin, well our team
> has done just that with the chrome.identity plugin which is available for
> vanilla cordova apps:
> https://github.com/MobileChromeApps/chrome-cordova/tree/master/plugins/chrome.identity
>
> That plugin specifically is getting a lot effort put into it from Max right
> now, so if there are any limitations just bring them up.
>
> -Michal
>
>
> On Tue, Sep 17, 2013 at 1:27 PM, Joe Bowser <bo...@gmail.com> wrote:
>
>> Hey
>>
>> It's come to my attention that InAppBrowser is terrible
>>
>> 1. We keep getting UI Thread errors
>> 2. The UI is awful (on Android)
>> 3. We can now move drawables in plugins
>>
>> So, I propose that we do a re-write of InAppBrowser and add the
>> ability to move drawable resources to plugman. Even though I think
>> that InAppBrowser sucks and that we should have plugins to use
>> different accounts on the device instead of Web OAuth, we're stuck
>> with this until someone gets around to actually doing it.
>>
>> So, Are people cool with this plugin getting re-worked?
>>
>> Joe
>>
Re: [Android] InAppBrowser re-write/update
Posted by Michal Mocny <mm...@chromium.org>.
+Max who has been finding some issues with what we have and trying to fix
them one by one. I'de love to see some UI sprucing, and I can't speak
specifically to the drawables.
You suggest that we use accounts on the device as a plugin, well our team
has done just that with the chrome.identity plugin which is available for
vanilla cordova apps:
https://github.com/MobileChromeApps/chrome-cordova/tree/master/plugins/chrome.identity
That plugin specifically is getting a lot effort put into it from Max right
now, so if there are any limitations just bring them up.
-Michal
On Tue, Sep 17, 2013 at 1:27 PM, Joe Bowser <bo...@gmail.com> wrote:
> Hey
>
> It's come to my attention that InAppBrowser is terrible
>
> 1. We keep getting UI Thread errors
> 2. The UI is awful (on Android)
> 3. We can now move drawables in plugins
>
> So, I propose that we do a re-write of InAppBrowser and add the
> ability to move drawable resources to plugman. Even though I think
> that InAppBrowser sucks and that we should have plugins to use
> different accounts on the device instead of Web OAuth, we're stuck
> with this until someone gets around to actually doing it.
>
> So, Are people cool with this plugin getting re-worked?
>
> Joe
>