[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6681: change-diskoffer: iops settings from new disk-offer should always used

[GitBox <gi...@apache.org>]

DaanHoogland commented on code in PR #6681:
URL: https://github.com/apache/cloudstack/pull/6681#discussion_r968210912


##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -1934,6 +1934,18 @@ private void validateVolumeReadyStateAndHypervisorChecks(VolumeVO volume, long c
         }
     }
 
+    private void setNewIopsLimits(VolumeVO volume, DiskOfferingVO newDiskOffering, Long[] newMinIops, Long[] newMaxIops) {
+        if (newDiskOffering.isCustomizedIops() != null && newDiskOffering.isCustomizedIops()) {

Review Comment:
   or `Boolean.TRUE.equals()`! I am not sure but I think the standard way is good enough. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org