You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/09 12:50:41 UTC
[GitHub] [incubator-doris] Jibing-Li opened a new pull request, #10044: [Draft]Change DatabaseIf APIs' return type to TableIf.
Jibing-Li opened a new pull request, #10044:
URL: https://github.com/apache/incubator-doris/pull/10044
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Change the DatabaseIf APIs' return type to TableIf.
Use generics in DatabaseIf, to avoid changing the return type in Database. Currently Database class use type Table, I'm try to avoid changing it to TableIf. Is there a better way to do that? Or is it better to change to TableIf? in which case, we need to change a lot of code.
Is there a way to keep the api in Database as
```public <T extends Table> T getTableOrMetaException```
so we don't need to convert the Table return type to its subclass?
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #10044: [feature](multi-catalog) Change DatabaseIf APIs' return type to TableIf.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10044:
URL: https://github.com/apache/incubator-doris/pull/10044#issuecomment-1153093005
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Jibing-Li commented on pull request #10044: [feature](multi-catalog) Change DatabaseIf APIs' return type to TableIf.
Posted by GitBox <gi...@apache.org>.
Jibing-Li commented on PR #10044:
URL: https://github.com/apache/incubator-doris/pull/10044#issuecomment-1151886264
> Will this pr change the function `public Table getTable()` in `TableRef`?
No, it doesn't change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #10044: [feature](multi-catalog) Change DatabaseIf APIs' return type to TableIf.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10044:
URL: https://github.com/apache/incubator-doris/pull/10044#issuecomment-1153093000
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] SaintBacchus commented on pull request #10044: [feature](multi-catalog) Change DatabaseIf APIs' return type to TableIf.
Posted by GitBox <gi...@apache.org>.
SaintBacchus commented on PR #10044:
URL: https://github.com/apache/incubator-doris/pull/10044#issuecomment-1151845579
Will this pr change the function `public Table getTable()` in `TableRef`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #10044: [feature](multi-catalog) Change DatabaseIf APIs' return type to TableIf.
Posted by GitBox <gi...@apache.org>.
morningman merged PR #10044:
URL: https://github.com/apache/incubator-doris/pull/10044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org