You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2011/11/15 12:52:14 UTC

DO NOT REPLY [Bug 52187] New: Duplicate entries in Test Plan User Defined Variables for build r1201923

https://issues.apache.org/bugzilla/show_bug.cgi?id=52187

             Bug #: 52187
           Summary: Duplicate entries in Test Plan User Defined Variables
                    for build r1201923
           Product: JMeter
           Version: Nightly (Please specify date)
          Platform: HP
            Status: NEW
          Severity: critical
          Priority: P1
         Component: Main
        AssignedTo: issues@jmeter.apache.org
        ReportedBy: rbargezi@infonic.net
    Classification: Unclassified


When loading a test plan with user defined variables, they get duplicated.

Reproduction steps:
- Open JMeter
- Add a user defined variable to the Test Plan element
- Save the Test Plan
- Open the Test Plan
=> the user defined variables show up twice

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 52187] Duplicate entries in Test Plan User Defined Variables for build r1201923

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52187

--- Comment #4 from Philippe Mouawad <p....@ubik-ingenierie.com> 2011-11-15 13:23:57 UTC ---
I rollbacked fix to 50799.
I don't have time to investigate for now, will do it this week-end.
In the meantime if you find something feel free to provide a patch.

Thanks

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 52187] Duplicate entries in Test Plan User Defined Variables for build r1201923

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52187

--- Comment #5 from Roman Bargezi <rb...@infonic.net> 2011-11-15 13:59:23 UTC ---
Additional observation:
The cloning of the test elements also floods memory like wild. For each sample,
the entire configuration gets cloned. If you have lots of lists of user defined
variables or other larger config entries, you soon end up in an
OutOfMemoryException.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 52187] Duplicate entries in Test Plan User Defined Variables for build r1201923

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52187

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Philippe Mouawad <p....@ubik-ingenierie.com> 2011-11-15 21:24:28 UTC ---
Fixed by revert on last 50799 fix.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 52187] Duplicate entries in Test Plan User Defined Variables for build r1201923

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52187

--- Comment #3 from Roman Bargezi <rb...@infonic.net> 2011-11-15 13:19:26 UTC ---
My investigations show the same. It's caused by the fact that during the merge
(AbstractTestElement.mergeIn) the properties are cloned. For a
CollectionProperty the equality test in MultiProperty.mergeIn then fails, which
id did not before the change.

This may though not be the root cause. I also observed that in the
Load.insertLoadedTree method, the test plan gets cleared and initialized with
the loaded test plan.

public static boolean insertLoadedTree(int id, HashTree tree, boolean merging)
throws Exception, IllegalUserActionException {
...
if(isTestPlan && !merging) {
   guiInstance.clearTestPlan((TestElement)tree.getArray()[0]);
}
...

further down in the code, the test plan is then added once more
...
HashTree newTree = guiInstance.addSubTree(tree);
...

which effectively results in merging in the test plan with itself. I'm not sure
if this is what the designers originally intended.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 52187] Duplicate entries in Test Plan User Defined Variables for build r1201923

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52187

Sebb <se...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         OS/Version|                            |All

--- Comment #1 from Sebb <se...@apache.org> 2011-11-15 12:37:54 UTC ---
I can confirm the problem, there is only one UDV, but the UDV entries are
duplicated.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 52187] Duplicate entries in Test Plan User Defined Variables for build r1201923

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52187

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |p.mouawad@ubik-ingenierie.c
                   |                            |om

--- Comment #2 from Philippe Mouawad <p....@ubik-ingenierie.com> 2011-11-15 13:08:39 UTC ---
This is a regression introduced by 50799.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.