You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/06/26 17:11:14 UTC
[GitHub] [guacamole-server] myjimmy opened a new pull request #296: Fix the destruction of some thread mutexes
myjimmy opened a new pull request #296:
URL: https://github.com/apache/guacamole-server/pull/296
I have fixed the GUACAMOLE-1114 issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] myjimmy commented on pull request #296: GUACAMOLE-1114: Fix the destruction of some thread mutexes
Posted by GitBox <gi...@apache.org>.
myjimmy commented on pull request #296:
URL: https://github.com/apache/guacamole-server/pull/296#issuecomment-650300206
> Actually, before merging this, could you adjust the commit messages a bit? They're very long and are "wrapping" around to multiple lines with the "..." that git inserts by default. If you could make these a little shorter - something like:
> Clean up print job mutex lock
> Clean up clipboard mutex lock
>
> That would be great.
OK. I'll adjust my commits.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] myjimmy commented on pull request #296: GUACAMOLE-1114: Fix the destruction of some thread mutexes
Posted by GitBox <gi...@apache.org>.
myjimmy commented on pull request #296:
URL: https://github.com/apache/guacamole-server/pull/296#issuecomment-650307262
@necouchman Could you let me know how to modify the submitted pull request?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] myjimmy commented on pull request #296: GUACAMOLE-1114: Fix the destruction of some thread mutexes
Posted by GitBox <gi...@apache.org>.
myjimmy commented on pull request #296:
URL: https://github.com/apache/guacamole-server/pull/296#issuecomment-650326790
> @myjimmy: You just push changes to your current branch - so, if you want to modify the commit messages, you'd go back and do:
> `git rebase -i <COMMIT BEFORE YOUR COMMIT>`
>
> and when you get prompted for the commits, use the "reword" option (r) to edit the commit messages. Once the rebase is done, do:
> `git push -f`
>
> and the changes will show up, here.
@necouchman: Thanks. I have just modified the comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] myjimmy commented on pull request #296: GUACAMOLE-1114: Fix the destruction of some thread mutexes
Posted by GitBox <gi...@apache.org>.
myjimmy commented on pull request #296:
URL: https://github.com/apache/guacamole-server/pull/296#issuecomment-650298675
> Looks good. Thanks @myjimmy!
@necouchman My pleasure!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] necouchman merged pull request #296: GUACAMOLE-1114: Fix the destruction of some thread mutexes
Posted by GitBox <gi...@apache.org>.
necouchman merged pull request #296:
URL: https://github.com/apache/guacamole-server/pull/296
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] necouchman commented on pull request #296: GUACAMOLE-1114: Fix the destruction of some thread mutexes
Posted by GitBox <gi...@apache.org>.
necouchman commented on pull request #296:
URL: https://github.com/apache/guacamole-server/pull/296#issuecomment-650309870
@myjimmy: You just push changes to your current branch - so, if you want to modify the commit messages, you'd go back and do:
```git rebase -i <COMMIT BEFORE YOUR COMMIT>```
and when you get prompted for the commits, use the "reword" option (r) to edit the commit messages. Once the rebase is done, do:
```git push -f```
and the changes will show up, here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org