You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/13 15:47:08 UTC

[GitHub] [beam] damccorm commented on a diff in pull request #17361: Fix a couple style issues

damccorm commented on code in PR #17361:
URL: https://github.com/apache/beam/pull/17361#discussion_r849639127


##########
sdks/go/pkg/beam/core/runtime/xlangx/registry.go:
##########
@@ -267,12 +267,12 @@ func Require(expansionAddr string) string {
 	return hardOverrideNamespace + Separator + expansionAddr
 }
 
-type expansionServiceOption func(*string)
+type ExpansionServiceOption func(*string)

Review Comment:
   Good call!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org