You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by Minxuan Zhuang <z8...@gmail.com> on 2019/02/18 06:03:19 UTC
how to deal with two pull requests to solve the same issue
Hi Community,
If two pull requests are aiming to solve the same issue, how to choose
from them?
Re:how to deal with two pull requests to solve the same issue
Posted by 柯振旭 <ke...@163.com>.
I suggest choosing by the following priority:
Code quality > Time the PR Created
At 2019-02-18 14:03:19, "Minxuan Zhuang" <z8...@gmail.com> wrote:
>Hi Community,
> If two pull requests are aiming to solve the same issue, how to choose
>from them?
Re: how to deal with two pull requests to solve the same issue
Posted by "Taosheng, Wei" <we...@foxmail.com>.
+1
If the pr introduce new feature or modify origin logic, the unit test should be considered!
------------------ Original ------------------
From: Huxing Zhang <hu...@apache.org>
Date: Mon,Feb 18,2019 5:28 PM
To: dev <de...@dubbo.apache.org>
Subject: Re: how to deal with two pull requests to solve the same issue
Re: how to deal with two pull requests to solve the same issue
Posted by LiZhenNet <li...@gmail.com>.
Hi, all
If PR is used to fix issue, Reviewer should help contributer associate PR
with issue.
This will make others know that some one is working at this issue.
This is what I found when I fixed
https://github.com/apache/incubator-dubbo/issues/3420.
Ian Luo <ia...@gmail.com> 于2019年2月18日周一 下午5:59写道：
> It happens but I believe it's rare. If it does happen, I agree with the
> ideas Huxing proposed.
>
> Regards,
> -Ian.
>
> On Mon, Feb 18, 2019 at 5:39 PM yuhang xiu <ca...@gmail.com> wrote:
>
> > Totally agree with huxing.
> > In addition, we may be able to remind the authors of the two prs that
> their
> > pr is repeated.
> > This will let them review the code and leave a comment. In some cases,
> > perhaps one of them will close their pr directly.
> >
> > Huxing Zhang <hu...@apache.org> 于2019年2月18日周一 下午5:28写道：
> >
> > > Hi,
> > >
> > > I remember I've seen this kind of issue before.
> > >
> > > From my point of view, I prefer the following precedence:
> > > - check the implementation, the code quality requirement should be
> > > satisfied.
> > > - if the quality looks more or less the same, I usually check if
> > > he/she is the first time contributor. I think we should be more
> > > generous to new comers.
> > >
> >
> > Can't agree more. We should involve more people. Getting more people to
> > contribute to dubbo is very important for the dubbo community, and we
> > should give this opportunity to newcomer.
> >
> >
> > > - if the above condition is not met, I tend to use FIFO based on the
> > > creation time of the pull request.
> > >
> > > This is my personal opinion, let's see what others might think.
> > >
> > > To avoid this issue, I do recommend people to leave a comment before
> > > start contributing.
> > >
> > > On Mon, Feb 18, 2019 at 2:03 PM Minxuan Zhuang <z8...@gmail.com>
> > > wrote:
> > > >
> > > > Hi Community,
> > > > If two pull requests are aiming to solve the same issue, how to
> > > choose
> > > > from them?
> > >
> > >
> > >
> > > --
> > > Best Regards！
> > > Huxing
> > >
> >
>
Re: how to deal with two pull requests to solve the same issue
Posted by Ian Luo <ia...@gmail.com>.
It happens but I believe it's rare. If it does happen, I agree with the
ideas Huxing proposed.
Regards,
-Ian.
On Mon, Feb 18, 2019 at 5:39 PM yuhang xiu <ca...@gmail.com> wrote:
> Totally agree with huxing.
> In addition, we may be able to remind the authors of the two prs that their
> pr is repeated.
> This will let them review the code and leave a comment. In some cases,
> perhaps one of them will close their pr directly.
>
> Huxing Zhang <hu...@apache.org> 于2019年2月18日周一 下午5:28写道：
>
> > Hi,
> >
> > I remember I've seen this kind of issue before.
> >
> > From my point of view, I prefer the following precedence:
> > - check the implementation, the code quality requirement should be
> > satisfied.
> > - if the quality looks more or less the same, I usually check if
> > he/she is the first time contributor. I think we should be more
> > generous to new comers.
> >
>
> Can't agree more. We should involve more people. Getting more people to
> contribute to dubbo is very important for the dubbo community, and we
> should give this opportunity to newcomer.
>
>
> > - if the above condition is not met, I tend to use FIFO based on the
> > creation time of the pull request.
> >
> > This is my personal opinion, let's see what others might think.
> >
> > To avoid this issue, I do recommend people to leave a comment before
> > start contributing.
> >
> > On Mon, Feb 18, 2019 at 2:03 PM Minxuan Zhuang <z8...@gmail.com>
> > wrote:
> > >
> > > Hi Community,
> > > If two pull requests are aiming to solve the same issue, how to
> > choose
> > > from them?
> >
> >
> >
> > --
> > Best Regards！
> > Huxing
> >
>
Re: how to deal with two pull requests to solve the same issue
Posted by yuhang xiu <ca...@gmail.com>.
Totally agree with huxing.
In addition, we may be able to remind the authors of the two prs that their
pr is repeated.
This will let them review the code and leave a comment. In some cases,
perhaps one of them will close their pr directly.
Huxing Zhang <hu...@apache.org> 于2019年2月18日周一 下午5:28写道：
> Hi,
>
> I remember I've seen this kind of issue before.
>
> From my point of view, I prefer the following precedence:
> - check the implementation, the code quality requirement should be
> satisfied.
> - if the quality looks more or less the same, I usually check if
> he/she is the first time contributor. I think we should be more
> generous to new comers.
>
Can't agree more. We should involve more people. Getting more people to
contribute to dubbo is very important for the dubbo community, and we
should give this opportunity to newcomer.
> - if the above condition is not met, I tend to use FIFO based on the
> creation time of the pull request.
>
> This is my personal opinion, let's see what others might think.
>
> To avoid this issue, I do recommend people to leave a comment before
> start contributing.
>
> On Mon, Feb 18, 2019 at 2:03 PM Minxuan Zhuang <z8...@gmail.com>
> wrote:
> >
> > Hi Community,
> > If two pull requests are aiming to solve the same issue, how to
> choose
> > from them?
>
>
>
> --
> Best Regards！
> Huxing
>
Re: how to deal with two pull requests to solve the same issue
Posted by Huxing Zhang <hu...@apache.org>.
Hi,
I remember I've seen this kind of issue before.
From my point of view, I prefer the following precedence:
- check the implementation, the code quality requirement should be satisfied.
- if the quality looks more or less the same, I usually check if
he/she is the first time contributor. I think we should be more
generous to new comers.
- if the above condition is not met, I tend to use FIFO based on the
creation time of the pull request.
This is my personal opinion, let's see what others might think.
To avoid this issue, I do recommend people to leave a comment before
start contributing.
On Mon, Feb 18, 2019 at 2:03 PM Minxuan Zhuang <z8...@gmail.com> wrote:
>
> Hi Community,
> If two pull requests are aiming to solve the same issue, how to choose
> from them?
--
Best Regards！
Huxing