You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Douglas Creager (JIRA)" <ji...@apache.org> on 2011/01/22 04:23:43 UTC
[jira] Created: (AVRO-742) Maintain reference counts for singleton
objects
Maintain reference counts for singleton objects
-----------------------------------------------
Key: AVRO-742
URL: https://issues.apache.org/jira/browse/AVRO-742
Project: Avro
Issue Type: Bug
Components: c
Reporter: Douglas Creager
Assignee: Douglas Creager
Attachments: 0001-Maintain-reference-count-for-singleton-objects.patch
We use singleton objects for the null Avro value, and for each of the primitive Avro schema types. They're initialized with a reference count of 1, and their reference counts are decremented with the avro_whatever_decref methods, but we don't increment them in the "constructor" methods. That causes the reference counts to get wonky. We don't ever free the static singleton instances, so we don't get any memory corruption, but it's still not very clean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-742) Maintain reference counts for singleton
objects
Posted by "Douglas Creager (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Douglas Creager updated AVRO-742:
---------------------------------
Attachment: 0001-Maintain-reference-count-for-singleton-objects.patch
Patch to keep accurate reference counts for singleton instances
> Maintain reference counts for singleton objects
> -----------------------------------------------
>
> Key: AVRO-742
> URL: https://issues.apache.org/jira/browse/AVRO-742
> Project: Avro
> Issue Type: Bug
> Components: c
> Reporter: Douglas Creager
> Assignee: Douglas Creager
> Attachments: 0001-Maintain-reference-count-for-singleton-objects.patch
>
>
> We use singleton objects for the null Avro value, and for each of the primitive Avro schema types. They're initialized with a reference count of 1, and their reference counts are decremented with the avro_whatever_decref methods, but we don't increment them in the "constructor" methods. That causes the reference counts to get wonky. We don't ever free the static singleton instances, so we don't get any memory corruption, but it's still not very clean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (AVRO-742) Maintain reference counts for singleton
objects
Posted by "Bruce Mitchener (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruce Mitchener resolved AVRO-742.
----------------------------------
Resolution: Fixed
Fix Version/s: 1.5.0
> Maintain reference counts for singleton objects
> -----------------------------------------------
>
> Key: AVRO-742
> URL: https://issues.apache.org/jira/browse/AVRO-742
> Project: Avro
> Issue Type: Bug
> Components: c
> Reporter: Douglas Creager
> Assignee: Douglas Creager
> Fix For: 1.5.0
>
> Attachments: 0001-Maintain-reference-count-for-singleton-objects.patch
>
>
> We use singleton objects for the null Avro value, and for each of the primitive Avro schema types. They're initialized with a reference count of 1, and their reference counts are decremented with the avro_whatever_decref methods, but we don't increment them in the "constructor" methods. That causes the reference counts to get wonky. We don't ever free the static singleton instances, so we don't get any memory corruption, but it's still not very clean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.