You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@fluo.apache.org by GitBox <gi...@apache.org> on 2019/11/20 01:01:20 UTC

[GitHub] [fluo-uno] mandarinamdar commented on a change in pull request #236: Fix #235 skip checksum check for snapshot version

mandarinamdar commented on a change in pull request #236: Fix #235 skip checksum check for snapshot version
URL: https://github.com/apache/fluo-uno/pull/236#discussion_r348246516
 
 

 ##########
 File path: bin/impl/load-env.sh
 ##########
 @@ -139,7 +139,7 @@ if [[ -z "$ZOOKEEPER_HASH" ]]; then
   echo "ZOOKEEPER_HASH is not set. Set it for your version in 'conf/checksums' or uno.conf"
   exit 1
 fi
-if [[ -z "$ACCUMULO_HASH" ]]; then
+if [[ -z "$ACCUMULO_HASH" && "$ACCUMULO_VERSION" != *"SNAPSHOT"* ]]; then
 
 Review comment:
   Thanks for the review @arvindshmicrosoft . Yes, right. I have included quotes mainly for consistency with the existing script

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services