You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/03/17 16:43:18 UTC
[GitHub] [activemq-artemis] clebertsuconic opened a new pull request #3025:
NO-JIRA Fixing GeneralInteropTest
clebertsuconic opened a new pull request #3025: NO-JIRA Fixing GeneralInteropTest
URL: https://github.com/apache/activemq-artemis/pull/3025
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] brusdev commented on a change in pull request
#3025: NO-JIRA Fixing GeneralInteropTest
Posted by GitBox <gi...@apache.org>.
brusdev commented on a change in pull request #3025: NO-JIRA Fixing GeneralInteropTest
URL: https://github.com/apache/activemq-artemis/pull/3025#discussion_r393904251
##########
File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/interop/GeneralInteropTest.java
##########
@@ -235,13 +235,15 @@ public void testFailoverReceivingFromCore() throws Exception {
}
}
+ Wait.assertEquals(0, queueControl::getDeliveringCount);
Review comment:
After the reconnection, the deliveringCount should be equal to the prefetchSize.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] brusdev commented on a change in pull request
#3025: NO-JIRA Fixing GeneralInteropTest
Posted by GitBox <gi...@apache.org>.
brusdev commented on a change in pull request #3025: NO-JIRA Fixing GeneralInteropTest
URL: https://github.com/apache/activemq-artemis/pull/3025#discussion_r393904344
##########
File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/interop/GeneralInteropTest.java
##########
@@ -235,13 +235,15 @@ public void testFailoverReceivingFromCore() throws Exception {
}
}
+ Wait.assertEquals(0, queueControl::getDeliveringCount);
+
message = consumer.receive(5000);
assertNotNull(message);
assertTrue(message instanceof TextMessage);
assertEquals(text + 1, ((TextMessage)message).getText());
message.acknowledge();
- Wait.assertEquals(2L, () -> queueControl.getMessagesAcknowledged(), 3000, 100);
+ Wait.assertEquals(1L, () -> queueControl.getMessagesAcknowledged(), 3000, 100);
Review comment:
After 2 acknowledges the count should be 2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] asfgit closed pull request #3025: NO-JIRA Fixing
GeneralInteropTest
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3025: NO-JIRA Fixing GeneralInteropTest
URL: https://github.com/apache/activemq-artemis/pull/3025
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] asfgit merged pull request #3025: NO-JIRA Fixing
GeneralInteropTest
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #3025: NO-JIRA Fixing GeneralInteropTest
URL: https://github.com/apache/activemq-artemis/pull/3025
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services