You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/11/01 13:24:02 UTC
[GitHub] [rocketmq-dashboard] suvllian opened a new pull request #36: feat: init frontend dashboard
suvllian opened a new pull request #36:
URL: https://github.com/apache/rocketmq-dashboard/pull/36
## What is the purpose of the change
#11
use ant design pro to setup frontend dashboard
## Brief changelog
1. choose frontend framework
2. init frontend dashboard
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] 1994 commented on pull request #36: feat: init frontend dashboard
Posted by GitBox <gi...@apache.org>.
1994 commented on pull request #36:
URL: https://github.com/apache/rocketmq-dashboard/pull/36#issuecomment-965101884
I suggest using Typescript instead of Javascript. Typescript is more friendly to Java developer and has better maintenance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] StyleTang commented on pull request #36: feat: init frontend dashboard
Posted by GitBox <gi...@apache.org>.
StyleTang commented on pull request #36:
URL: https://github.com/apache/rocketmq-dashboard/pull/36#issuecomment-966362830
> I suggest using Typescript instead of Javascript. Typescript is more friendly to Java developer and has better maintenance.
@1994
Agree, strongly typed languages are easier to maintain, this PR already using Typescript.
Are you interested in contributing together~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] vongosling commented on pull request #36: feat: init frontend dashboard
Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #36:
URL: https://github.com/apache/rocketmq-dashboard/pull/36#issuecomment-957025218
We should point to the new dev branch for this architecture update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] StyleTang commented on pull request #36: feat: init frontend dashboard
Posted by GitBox <gi...@apache.org>.
StyleTang commented on pull request #36:
URL: https://github.com/apache/rocketmq-dashboard/pull/36#issuecomment-957848753
Thanks👍, this is really a huge change, could you change the merge branch to develop?
I have 2 overall comments:
1. There are a lot of useless files that need to be deleted, we should keep our project simple and easy to maintain.
2. Need to add the Apache V2 license header to each file.
There might be a lot of work to do, I will work with you to finish this PR.
Thanks again for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] StyleTang commented on pull request #36: feat: init frontend dashboard
Posted by GitBox <gi...@apache.org>.
StyleTang commented on pull request #36:
URL: https://github.com/apache/rocketmq-dashboard/pull/36#issuecomment-957848753
Thanks👍, this is really a huge change, could you change the merge branch to develop?
I have 2 overall comments:
1. There are a lot of useless files that need to be deleted, we should keep our project simple and easy to maintain.
2. Need to add the Apache V2 license header to each file.
There might be a lot of work to do, I will work with you to finish this PR.
Thanks again for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] StyleTang merged pull request #36: feat: init frontend dashboard
Posted by GitBox <gi...@apache.org>.
StyleTang merged pull request #36:
URL: https://github.com/apache/rocketmq-dashboard/pull/36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] StyleTang commented on pull request #36: feat: init frontend dashboard
Posted by GitBox <gi...@apache.org>.
StyleTang commented on pull request #36:
URL: https://github.com/apache/rocketmq-dashboard/pull/36#issuecomment-957848753
Thanks👍, this is really a huge change, could you change the merge branch to develop?
I have 2 overall comments:
1. There are a lot of useless files that need to be deleted, we should keep our project simple and easy to maintain.
2. Need to add the Apache V2 license header to each file.
There might be a lot of work to do, I will work with you to finish this PR.
Thanks again for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] vongosling commented on pull request #36: feat: init frontend dashboard
Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #36:
URL: https://github.com/apache/rocketmq-dashboard/pull/36#issuecomment-957025218
We should point to the new dev branch for this architecture update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] vongosling commented on pull request #36: feat: init frontend dashboard
Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #36:
URL: https://github.com/apache/rocketmq-dashboard/pull/36#issuecomment-957025218
We should point to the new dev branch for this architecture update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org