You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Anshul Gangwar <an...@citrix.com> on 2014/08/04 08:08:52 UTC

Review Request 24226: CLOUDSTACK-7234: stop sending smb credentials to Hyper-V Agent

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24226/
-----------------------------------------------------------

Review request for cloudstack, Devdeep Singh and Rajesh Battala.


Bugs: CLOUDSTACK-7234
    https://issues.apache.org/jira/browse/CLOUDSTACK-7234


Repository: cloudstack-git


Description
-------

We no longer uses SMB credentials on Hyper-V Agent so we are stopping to send SMB credentials to Hyper-V


Diffs
-----

  engine/schema/src/org/apache/cloudstack/storage/datastore/db/StoragePoolVO.java 1508ce0 
  plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/CloudStackTypes.cs 4516191 
  plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/Utils.cs b40cb8f 
  plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java 2671b20 

Diff: https://reviews.apache.org/r/24226/diff/


Testing
-------

verified on Hyper-V agent that we are not receiving SMB credentials.


Thanks,

Anshul Gangwar


Re: Review Request 24226: CLOUDSTACK-7234: stop sending smb credentials to Hyper-V Agent

Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24226/#review50862
-----------------------------------------------------------

Ship it!


Pushed to master in commit 0ecc9f79af0f915ac347f856c3c2f8ce40f636af

- Devdeep Singh


On Aug. 4, 2014, 6:08 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24226/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2014, 6:08 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
> 
> 
> Bugs: CLOUDSTACK-7234
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7234
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> We no longer uses SMB credentials on Hyper-V Agent so we are stopping to send SMB credentials to Hyper-V
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/org/apache/cloudstack/storage/datastore/db/StoragePoolVO.java 1508ce0 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/CloudStackTypes.cs 4516191 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/Utils.cs b40cb8f 
>   plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java 2671b20 
> 
> Diff: https://reviews.apache.org/r/24226/diff/
> 
> 
> Testing
> -------
> 
> verified on Hyper-V agent that we are not receiving SMB credentials.
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>