You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2015/12/17 20:51:16 UTC
Re: Review Request 41188: Providing JSON bindings to expose
DiscoveryInfo protobuf messages to HTTP endpoints
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41188/
-----------------------------------------------------------
(Updated Dec. 17, 2015, 7:51 p.m.)
Review request for mesos, Adam B and Anand Mazumdar.
Summary (updated)
-----------------
Providing JSON bindings to expose DiscoveryInfo protobuf messages to HTTP endpoints
Bugs: MESOS-3962
https://issues.apache.org/jira/browse/MESOS-3962
Repository: mesos
Description
-------
Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints
Diffs
-----
src/slave/http.cpp d1b1158c0a80d72c32c9b28977043b6be2295239
src/tests/common/http_tests.cpp 3aca5b0437a012664f58ff331cc7cf682d442699
src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5
Diff: https://reviews.apache.org/r/41188/diff/
Testing
-------
make check.
Added Unit tests to verify setting of DiscoveryInfo in state.json in slave.
Also added Unit test to test that DiscoveryInfo gets exposed in master when TaskInfo protobuf is converted to JSON objects.
Thanks,
Avinash sridharan
Re: Review Request 41188: Providing JSON bindings to expose
DiscoveryInfo protobuf messages to HTTP endpoints
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41188/#review111105
-----------------------------------------------------------
Ship it!
Minor correction+suggestion. Ready to commit once you're done.
src/tests/common/http_tests.cpp (line 74)
<https://reviews.apache.org/r/41188/#comment171089>
Again, you probably want a different example, if 'vip' is about to be a new DiscoveryInfo field.
src/tests/slave_tests.cpp (line 2214)
<https://reviews.apache.org/r/41188/#comment171092>
s/master/slave/
- Adam B
On Dec. 17, 2015, 2:40 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41188/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 2:40 p.m.)
>
>
> Review request for mesos, Adam B and Anand Mazumdar.
>
>
> Bugs: MESOS-3962
> https://issues.apache.org/jira/browse/MESOS-3962
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints
>
>
> Diffs
> -----
>
> src/slave/http.cpp d1b1158c0a80d72c32c9b28977043b6be2295239
> src/tests/common/http_tests.cpp 3aca5b0437a012664f58ff331cc7cf682d442699
> src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5
>
> Diff: https://reviews.apache.org/r/41188/diff/
>
>
> Testing
> -------
>
> make check.
> Added Unit tests to verify setting of DiscoveryInfo in state.json in slave.
> Also added Unit test to test that DiscoveryInfo gets exposed in master when TaskInfo protobuf is converted to JSON objects.
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 41188: Providing JSON bindings to expose
DiscoveryInfo protobuf messages to HTTP endpoints
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41188/#review111111
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41187, 41188]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 18, 2015, 2:45 a.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41188/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 2:45 a.m.)
>
>
> Review request for mesos, Adam B and Anand Mazumdar.
>
>
> Bugs: MESOS-3962
> https://issues.apache.org/jira/browse/MESOS-3962
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints
>
>
> Diffs
> -----
>
> src/slave/http.cpp d1b1158c0a80d72c32c9b28977043b6be2295239
> src/tests/common/http_tests.cpp 3aca5b0437a012664f58ff331cc7cf682d442699
> src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5
>
> Diff: https://reviews.apache.org/r/41188/diff/
>
>
> Testing
> -------
>
> make check.
> Added Unit tests to verify setting of DiscoveryInfo in state.json in slave.
> Also added Unit test to test that DiscoveryInfo gets exposed in master when TaskInfo protobuf is converted to JSON objects.
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 41188: Providing JSON bindings to expose
DiscoveryInfo protobuf messages to HTTP endpoints
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41188/
-----------------------------------------------------------
(Updated Dec. 18, 2015, 2:45 a.m.)
Review request for mesos, Adam B and Anand Mazumdar.
Bugs: MESOS-3962
https://issues.apache.org/jira/browse/MESOS-3962
Repository: mesos
Description
-------
Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints
Diffs (updated)
-----
src/slave/http.cpp d1b1158c0a80d72c32c9b28977043b6be2295239
src/tests/common/http_tests.cpp 3aca5b0437a012664f58ff331cc7cf682d442699
src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5
Diff: https://reviews.apache.org/r/41188/diff/
Testing
-------
make check.
Added Unit tests to verify setting of DiscoveryInfo in state.json in slave.
Also added Unit test to test that DiscoveryInfo gets exposed in master when TaskInfo protobuf is converted to JSON objects.
Thanks,
Avinash sridharan
Re: Review Request 41188: Providing JSON bindings to expose
DiscoveryInfo protobuf messages to HTTP endpoints
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41188/
-----------------------------------------------------------
(Updated Dec. 17, 2015, 10:40 p.m.)
Review request for mesos, Adam B and Anand Mazumdar.
Bugs: MESOS-3962
https://issues.apache.org/jira/browse/MESOS-3962
Repository: mesos
Description
-------
Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints
Diffs (updated)
-----
src/slave/http.cpp d1b1158c0a80d72c32c9b28977043b6be2295239
src/tests/common/http_tests.cpp 3aca5b0437a012664f58ff331cc7cf682d442699
src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5
Diff: https://reviews.apache.org/r/41188/diff/
Testing
-------
make check.
Added Unit tests to verify setting of DiscoveryInfo in state.json in slave.
Also added Unit test to test that DiscoveryInfo gets exposed in master when TaskInfo protobuf is converted to JSON objects.
Thanks,
Avinash sridharan