You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/01 06:13:31 UTC

[GitHub] [airflow] uranusjr commented on a change in pull request #22671: Support for sorting DAGs in the web UI

uranusjr commented on a change in pull request #22671:
URL: https://github.com/apache/airflow/pull/22671#discussion_r840263600



##########
File path: airflow/www/views.py
##########
@@ -740,13 +742,12 @@ def index(self):
                 current_dags = all_dags
                 num_of_all_dags = all_dags_count
 
-            dags = (
-                current_dags.order_by(DagModel.dag_id)
-                .options(joinedload(DagModel.tags))
-                .offset(start)
-                .limit(dags_per_page)
-                .all()
+            sort_column = DagModel.__table__.c[arg_sorting_key]

Review comment:
       This should add a fallback if the sorting key is invalid.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org