[ https://issues.apache.org/struts/browse/TILES-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli moved SB-102 to TILES-30:
------------------------------------------
Fix Version/s: (was: 2.0)
2.0.0
Component/s: (was: Tiles)
core
Affects Version/s: (was: 2.0)
2.0.0
Workflow: Struts (was: jira)
Key: TILES-30 (was: SB-102)
Project: Tiles (was: Sandbox)
> ComponentDefinitionsImpl incorectly recurses on child rather than parent definition
> -----------------------------------------------------------------------------------
>
> Key: TILES-30
> URL: https://issues.apache.org/struts/browse/TILES-30
> Project: Tiles
> Issue Type: Bug
> Components: core
> Affects Versions: 2.0.0
> Reporter: Joe Pemberton
> Assigned To: Antonio Petrelli
> Fix For: 2.0.0
>
>
> I believe that ComponentDefinitionsImpl.resolveInheritance(ComponentDefinition, Locale) incorrectly recurses on the child definition instead of the parent definition. Since it does not call resolveInheritance() on the parent definition, the child does not inherit any of the parent's attributes unless the parent has already been visited.
> The very simple fix that took me much head scratching and guessing to find:
> --- tiles-core/src/main/java/org/apache/tiles/definition/ComponentDefinitionsImpl.java (revision 488454)
> +++ tiles-core/src/main/java/org/apache/tiles/definition/ComponentDefinitionsImpl.java (working copy)
> @@ -329,7 +329,7 @@
> throw new NoSuchDefinitionException(msg);
> }
> - resolveInheritance(definition, locale);
> + resolveInheritance(parent, locale);
> overload(parent, definition);
> }
> p.s. keep up the great work, guys. I can't wait to deploy Tiles2+Struts2 in production.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.