You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/20 23:36:58 UTC
[GitHub] [pulsar] yannick opened a new pull request #13417: reference the relevant config settings for retention policies
yannick opened a new pull request #13417:
URL: https://github.com/apache/pulsar/pull/13417
minimal improvement for the docs so retention policy explanation can be found via search engine by looking for the config setting name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #13417: reference the relevant config settings for retention policies
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13417:
URL: https://github.com/apache/pulsar/pull/13417#issuecomment-998349294
@yannick:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #13417: reference the relevant config settings for retention policies
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #13417:
URL: https://github.com/apache/pulsar/pull/13417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #13417: reference the relevant config settings for retention policies
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #13417:
URL: https://github.com/apache/pulsar/pull/13417#discussion_r772925392
##########
File path: site2/docs/cookbooks-retention-expiry.md
##########
@@ -31,7 +31,7 @@ By default, when a Pulsar message arrives at a broker, the message is stored unt
Retention policies are useful when you use the Reader interface. The Reader interface does not use acknowledgements, and messages do not exist within backlogs. It is required to configure retention for Reader-only use cases.
-When you set a retention policy on topics in a namespace, you must set **both** a *size limit* and a *time limit*. You can refer to the following table to set retention policies in `pulsar-admin` and Java.
+When you set a retention policy on topics in a namespace, you must set **both** a *size limit* (via `defaultRetentionSizeInMB`) and a *time limit* (via `defaultRetentionTimeInMinutes`) . You can refer to the following table to set retention policies in `pulsar-admin` and Java.
Review comment:
@freeznet can you review this PR from the technical perspective? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #13417: reference the relevant config settings for retention policies
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #13417:
URL: https://github.com/apache/pulsar/pull/13417#discussion_r772925392
##########
File path: site2/docs/cookbooks-retention-expiry.md
##########
@@ -31,7 +31,7 @@ By default, when a Pulsar message arrives at a broker, the message is stored unt
Retention policies are useful when you use the Reader interface. The Reader interface does not use acknowledgements, and messages do not exist within backlogs. It is required to configure retention for Reader-only use cases.
-When you set a retention policy on topics in a namespace, you must set **both** a *size limit* and a *time limit*. You can refer to the following table to set retention policies in `pulsar-admin` and Java.
+When you set a retention policy on topics in a namespace, you must set **both** a *size limit* (via `defaultRetentionSizeInMB`) and a *time limit* (via `defaultRetentionTimeInMinutes`) . You can refer to the following table to set retention policies in `pulsar-admin` and Java.
Review comment:
@freeznet can you review this PR from the technical perspective? Thanks
FYI:
https://pulsar.apache.org/docs/en/reference-configuration/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #13417: reference the relevant config settings for retention policies
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #13417:
URL: https://github.com/apache/pulsar/pull/13417#issuecomment-998575645
Hi @yannick
You delete the backticks (``) so that Bot can not recognize the info and then labels the PR with `doc-info-missing`.
[x] `doc-required` ✅
[x] doc-required ❌
I've labelled this PR w/ `doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org