You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/01 01:23:43 UTC

[GitHub] [pulsar] liangyepianzhou opened a new pull request #12560: [Transaction]Optimize Tests extends from TransactionTest

liangyepianzhou opened a new pull request #12560:
URL: https://github.com/apache/pulsar/pull/12560


   ### Motivation
   Extract common codes to reduce code redundancy.
   Avoid the need to write repetitive code  when a Class extend TransactionTestBase.
   
   ### Modifications
   Extract the code for creating Tc and the Topic for testing into the parent class.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
    - [x ] `no-need-doc` 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #12560: [Transaction]Optimize Tests extends from TransactionTest

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12560:
URL: https://github.com/apache/pulsar/pull/12560#issuecomment-955846580


   @liangyepianzhou:Thanks for providing doc info!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #12560: [Transaction]Optimize the tests extends from TransactionTestBase

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #12560:
URL: https://github.com/apache/pulsar/pull/12560


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #12560: [Transaction]Optimize the tests extends from TransactionTestBase

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #12560:
URL: https://github.com/apache/pulsar/pull/12560


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org