You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/07/09 14:10:18 UTC

[GitHub] [shardingsphere] zrsaber opened a new pull request, #18979: Handling of star in select statement in postgresql

zrsaber opened a new pull request, #18979:
URL: https://github.com/apache/shardingsphere/pull/18979

   Fixes #18078.
   
   Changes proposed in this pull request:
   - fix handling of star in select statement
   -
   -
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] terrymanu merged pull request #18979: Handling of star in select statement in postgresql

Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #18979:
URL: https://github.com/apache/shardingsphere/pull/18979


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] zrsaber commented on pull request #18979: Handling of star in select statement in postgresql

Posted by GitBox <gi...@apache.org>.
zrsaber commented on PR #18979:
URL: https://github.com/apache/shardingsphere/pull/18979#issuecomment-1179681167

   Visitor and statement are implemented in the SELECT statement. The error is not reported because the G4 file is not parsed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] codecov-commenter commented on pull request #18979: Handling of star in select statement in postgresql

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18979:
URL: https://github.com/apache/shardingsphere/pull/18979#issuecomment-1179557372

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18979?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#18979](https://codecov.io/gh/apache/shardingsphere/pull/18979?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (622899a) into [master](https://codecov.io/gh/apache/shardingsphere/commit/f03bba1c6f82df29821b71ce26638befadc47b13?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f03bba1) will **decrease** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18979      +/-   ##
   ============================================
   - Coverage     59.37%   59.36%   -0.02%     
     Complexity     2316     2316              
   ============================================
     Files          3799     3799              
     Lines         54696    54671      -25     
     Branches       9242     9241       -1     
   ============================================
   - Hits          32478    32456      -22     
     Misses        19485    19485              
   + Partials       2733     2730       -3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/18979?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...he/shardingsphere/mode/manager/ContextManager.java](https://codecov.io/gh/apache/shardingsphere/pull/18979/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvbWFuYWdlci9Db250ZXh0TWFuYWdlci5qYXZh) | `63.29% <0.00%> (-3.84%)` | :arrow_down: |
   | [...e/mode/manager/switcher/ResourceSwitchManager.java](https://codecov.io/gh/apache/shardingsphere/pull/18979/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvbWFuYWdlci9zd2l0Y2hlci9SZXNvdXJjZVN3aXRjaE1hbmFnZXIuamF2YQ==) | `95.23% <0.00%> (+9.52%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18979?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18979?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f03bba1...622899a](https://codecov.io/gh/apache/shardingsphere/pull/18979?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org