You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/07 08:18:40 UTC

[GitHub] [flink-docker] zentol opened a new pull request #28: [FLINK-18506] Extract Flink version from URL

zentol opened a new pull request #28:
URL: https://github.com/apache/flink-docker/pull/28


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-docker] zentol merged pull request #28: [FLINK-18506] Extract Flink version from URL

Posted by GitBox <gi...@apache.org>.

zentol merged pull request #28:
URL: https://github.com/apache/flink-docker/pull/28


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-docker] carp84 commented on a change in pull request #28: [FLINK-18506] Extract Flink version from URL

Posted by GitBox <gi...@apache.org>.

carp84 commented on a change in pull request #28:
URL: https://github.com/apache/flink-docker/pull/28#discussion_r450726466



##########
File path: generate-stackbrew-library.sh
##########
@@ -94,7 +94,8 @@ for scala_version in "${scala_versions[@]}"; do
     commit="$(dirCommit "$dir")"
 
     # Extract the full Flink version from the Dockerfile
-    flink_version="$(git show "$commit":"$dir/Dockerfile" | awk '/ENV FLINK_VERSION=(.*) /{ split($2,a,"="); print a[2]}')"
+    flink_version="$(git show "$commit":"$dir/Dockerfile" | grep 'dist/flink/flink-[0-9.]*' | cut -d/ -f6 | cut -d- -f2"

Review comment:
       ```suggestion
       flink_version="$(git show "$commit":"$dir/Dockerfile" | grep 'dist/flink/flink-[0-9.]*' | cut -d/ -f6 | cut -d- -f2)"
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org