Perl API SVN::Ra get_commit_editor* functions broken, missing, untested

[Markus Kuhn <Ma...@cl.cam.ac.uk>]

BUG REPORT: The test cases for the Perl API SVN::Ra at

  http://svn.apache.org/repos/asf/subversion/trunk/subversion/bindings/swig/perl/native/t/6ra.t

currently lack tests for any of the functions needed to commit a change
to the repository via the remote-access API layer. For starters, there
are no tests for get_commit_editor, get_commit_editor2,
get_commit_editor3. (The SVN::Ra man page even says that the author did
not succeed in testing these functions ...)

When I try to use e.g. get_commit_editor2 as suggested in the SVN::Ra
man page, I just get an error message like

  TypeError in method 'svn_ra_get_commit_editor2', argument 5 of type 'svn_commit_callback2_t'

A short example Perl script that reproduces this is attached below.

Motivation: The remote-access layer API is very useful for applications
(such as Web CGI editors) that want to commit changes without the
overhead and disk-state involved with having to checkout a working
directory first. Perl remains a popular CGI scripting language, which
makes a well-tested, production-quality Perl SWIG binding for svn_ra.h
highly desirable.

See also: http://mail-archives.apache.org/mod_mbox/subversion-users/201007.mbox/browser

Markus

-- 
Markus Kuhn, Computer Laboratory, University of Cambridge
http://www.cl.cam.ac.uk/~mgk25/ || CB3 0FD, Great Britain

Re: Perl API SVN::Ra get_commit_editor* functions broken, missing, untested

[Stefan Sperling <st...@elego.de>]

On Mon, Jul 12, 2010 at 02:19:43PM +0100, Markus Kuhn wrote:
> BUG REPORT: The test cases for the Perl API SVN::Ra at
> 
>   http://svn.apache.org/repos/asf/subversion/trunk/subversion/bindings/swig/perl/native/t/6ra.t
> 
> currently lack tests for any of the functions needed to commit a change
> to the repository via the remote-access API layer. For starters, there
> are no tests for get_commit_editor, get_commit_editor2,
> get_commit_editor3. (The SVN::Ra man page even says that the author did
> not succeed in testing these functions ...)
> 
> When I try to use e.g. get_commit_editor2 as suggested in the SVN::Ra
> man page, I just get an error message like
> 
>   TypeError in method 'svn_ra_get_commit_editor2', argument 5 of type 'svn_commit_callback2_t'
> 
> A short example Perl script that reproduces this is attached below.

Feel free to file an issue.
Hopefully someone will find the time to look at this.

If you're able to produce a patch that fixes this, that would be great.

Thanks,
Stefan

Re: Perl API SVN::Ra get_commit_editor* functions broken, missing, untested

[Hyrum Wright <hy...@hyrumwright.org>]

On Mon, Jul 12, 2010 at 8:19 AM, Markus Kuhn <Ma...@cl.cam.ac.uk> wrote:
> BUG REPORT: The test cases for the Perl API SVN::Ra at
>
>  http://svn.apache.org/repos/asf/subversion/trunk/subversion/bindings/swig/perl/native/t/6ra.t
>
> currently lack tests for any of the functions needed to commit a change
> to the repository via the remote-access API layer. For starters, there
> are no tests for get_commit_editor, get_commit_editor2,
> get_commit_editor3. (The SVN::Ra man page even says that the author did
> not succeed in testing these functions ...)
>
> When I try to use e.g. get_commit_editor2 as suggested in the SVN::Ra
> man page, I just get an error message like
>
>  TypeError in method 'svn_ra_get_commit_editor2', argument 5 of type 'svn_commit_callback2_t'
>
> A short example Perl script that reproduces this is attached below.
>
> Motivation: The remote-access layer API is very useful for applications
> (such as Web CGI editors) that want to commit changes without the
> overhead and disk-state involved with having to checkout a working
> directory first. Perl remains a popular CGI scripting language, which
> makes a well-tested, production-quality Perl SWIG binding for svn_ra.h
> highly desirable.
>
> See also: http://mail-archives.apache.org/mod_mbox/subversion-users/201007.mbox/browser

Markus,
Thanks for your interest in the Perl bindings.  I agree that having
full and functioning Perl bindings is highly desirable, but
unfortunately, there aren't any active developers with the expertise
or time to maintain them properly.  As such, the Perl bindings haven't
been updated in quite some time.

It appears that you have some idea of what needs to be done, would you
like to try your hand at improving the Perl bindings?

Thanks,
-Hyrum