You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "waynexia (via GitHub)" <gi...@apache.org> on 2024/02/18 14:48:47 UTC

[PR] Taplo format [arrow-datafusion]

waynexia opened a new pull request, #9263:
URL: https://github.com/apache/arrow-datafusion/pull/9263

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes https://github.com/apache/arrow-datafusion/issues/9262.
   
   ## Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   See https://github.com/apache/arrow-datafusion/issues/9262 for details.
   
   ## What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   Changes:
   - Add taplo to CI
   - Format existing `Cargo.toml` files
   - Add a configuration file
   - Update related docs
   
   To install `taplo`, run `cargo install taplo-cli`. Or by other ways in [document](https://taplo.tamasfe.dev/cli/installation/binary.html).
   
   To format toml files, use `taplo format`. It would read config file `taplo.toml` from this PR.
   
   ## Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   no need
   
   ## Are there any user-facing changes?
   
   For developers, yes.
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] chore: use taplo to format Cargo.toml manifests [arrow-datafusion]

Posted by "Omega359 (via GitHub)" <gi...@apache.org>.
Omega359 commented on PR #9263:
URL: https://github.com/apache/arrow-datafusion/pull/9263#issuecomment-1956807477

   This broke /dev/rust-lint.sh because 
   
   /ci/scripts/rust_toml_fmt.sh isn't valid bash:
   
   set -ex
   taplo format
   done <-- this should be removed.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] chore: use taplo to format Cargo.toml manifests [arrow-datafusion]

Posted by "waynexia (via GitHub)" <gi...@apache.org>.
waynexia merged PR #9263:
URL: https://github.com/apache/arrow-datafusion/pull/9263


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Taplo format [arrow-datafusion]

Posted by "waynexia (via GitHub)" <gi...@apache.org>.
waynexia commented on PR #9263:
URL: https://github.com/apache/arrow-datafusion/pull/9263#issuecomment-1951614407

   Thanks for reviewing this @Jefffrey 
   
   I added a rule to skip reordering `package` table, it should look better now. Please check it out 😆 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] chore: use taplo to format Cargo.toml manifests [arrow-datafusion]

Posted by "waynexia (via GitHub)" <gi...@apache.org>.
waynexia commented on PR #9263:
URL: https://github.com/apache/arrow-datafusion/pull/9263#issuecomment-1956879740

   Ahhh my bad 😵‍💫 Are you willing to submit a fix?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org