You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2016/12/18 22:25:34 UTC

[GitHub] storm pull request #1834: STORM-2244 Some shaded jars doesn't exclude depend...

GitHub user HeartSaVioR opened a pull request:

    https://github.com/apache/storm/pull/1834

    STORM-2244 Some shaded jars doesn't exclude dependency signature files

    * Add filter option to all of shade plugin configurations

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HeartSaVioR/storm STORM-2244

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1834.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1834
    
----
commit e320eac4673dcf90336bf088a8b1e19ff75be9c1
Author: Jungtaek Lim <ka...@gmail.com>
Date:   2016-12-18T22:24:08Z

    STORM-2244 Some shaded jars doesn't exclude dependency signature files
    
    * Add filter option to all of shade plugin configurations

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1834: STORM-2244 Some shaded jars doesn't exclude dependency si...

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/1834
  
    @harshach Just missed this. I'll create pull request against 1.x branch soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1834: STORM-2244 Some shaded jars doesn't exclude dependency si...

Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the issue:

    https://github.com/apache/storm/pull/1834
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1834: STORM-2244 Some shaded jars doesn't exclude dependency si...

Posted by hmcl <gi...@git.apache.org>.
Github user hmcl commented on the issue:

    https://github.com/apache/storm/pull/1834
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1834: STORM-2244 Some shaded jars doesn't exclude depend...

Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1834#discussion_r93296871
  
    --- Diff: examples/storm-elasticsearch-examples/pom.xml ---
    @@ -62,6 +62,23 @@
                     <artifactId>maven-shade-plugin</artifactId>
                     <configuration>
                         <createDependencyReducedPom>true</createDependencyReducedPom>
    +                    <filters>
    --- End diff --
    
    I'm wondering if it would work to put this in PluginManagement in the root pom instead?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1834: STORM-2244 Some shaded jars doesn't exclude dependency si...

Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the issue:

    https://github.com/apache/storm/pull/1834
  
    @HeartSaVioR can you open a PR for 1.x-branch as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1834: STORM-2244 Some shaded jars doesn't exclude depend...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/1834


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---