FYI, JmsEndpoint.consumerType removed but still in docs

[Barry Kaplan <gr...@memelet.com>]

I see it was removed in revision 1067441. Yet the web site docs still how it
as an option. Also I could not find any indication in the release notes that
it was removed and why.

--
View this message in context: http://camel.465427.n5.nabble.com/FYI-JmsEndpoint-consumerType-removed-but-still-in-docs-tp4291400p4291400.html
Sent from the Camel - Users mailing list archive at Nabble.com.

Reinstating JMS SimpleMessageListenerContainer

[Joshua Watkins <jo...@gamesys.co.uk>]

A while ago there was a discussion topic that the
SimpleMessageListenerContainer/ConsumerType.Simple was removed from
camel-jms as it was deprecated. However from looking at the latest Spring
docs ( 
http://static.springsource.org/spring/docs/3.1.0.M1/javadoc-api/org/springf
ramework/jms/listener/SimpleMessageListenerContainer.html ) it is alive
and kicking.

Is there another reason that this feature was removed?

The reason I am so keen on the SimpleMessageListenerContainer is that the
DefaultMessageListenerContainer does not allow you to constrain the number
of threads used in a useful way. If you give it a task executor with a
maximum 5 threads and want to listen on 10 routes, only 5 of those routes
would be consumed from. There is even a note about this fact in the docs (
http://static.springsource.org/spring/docs/3.1.0.M1/javadoc-api/org/springf
ramework/jms/listener/DefaultMessageListenerContainer.html#setTaskExecutor(
java.util.concurrent.Executor) ). This makes the
SimpleMessageListenerContainer invaluable for scaling out an application
using camel-jms.


-josh

Re: FYI, JmsEndpoint.consumerType removed but still in docs

[Joshua Watkins <jo...@gamesys.co.uk>]

Hadrian,

I don't see that the SimpleMessageListenerContainer is deprecated in
3.0.5_RELEASE 
(http://static.springsource.org/spring/docs/3.0.5.RELEASE/javadoc-api/org/s
pringframework/jms/listener/SimpleMessageListenerContainer.html).

The reason I bring this up is that when using the
DefaultMessageListenerContainer (which JmsMessageListenerContainer
extends) a new listener thread is created for every JMS consumer route in
camel. However utilizing the SimpleMessageListenerContainer and a thread
pool bounds the number of threads created.

-josh

On 08/04/2011 18:23, "Hadrian Zbarcea" <hz...@gmail.com> wrote:

>Hi Barry, 
>
>Claus made that change part of the upgrade to spring 3 because the
>SimpleMessageListenerContainer was deprecated. Therefore the consumerType
>made no sense anymore as you only have one option, the
>JmsMessageListenerContainer. I'll update the docs. Thanks for reporting
>this!
>
>Hadrian
>
>On Apr 8, 2011, at 1:00 PM, Barry Kaplan wrote:
>
>> I see it was removed in revision 1067441. Yet the web site docs still
>>how it
>> as an option. Also I could not find any indication in the release notes
>>that
>> it was removed and why.
>> 
>> --
>> View this message in context:
>>http://camel.465427.n5.nabble.com/FYI-JmsEndpoint-consumerType-removed-bu
>>t-still-in-docs-tp4291400p4291400.html
>> Sent from the Camel - Users mailing list archive at Nabble.com.
>

Re: FYI, JmsEndpoint.consumerType removed but still in docs

[Hadrian Zbarcea <hz...@gmail.com>]

Hi Barry, 

Claus made that change part of the upgrade to spring 3 because the SimpleMessageListenerContainer was deprecated. Therefore the consumerType made no sense anymore as you only have one option, the JmsMessageListenerContainer. I'll update the docs. Thanks for reporting this!

Hadrian

On Apr 8, 2011, at 1:00 PM, Barry Kaplan wrote:

> I see it was removed in revision 1067441. Yet the web site docs still how it
> as an option. Also I could not find any indication in the release notes that
> it was removed and why.
> 
> --
> View this message in context: http://camel.465427.n5.nabble.com/FYI-JmsEndpoint-consumerType-removed-but-still-in-docs-tp4291400p4291400.html
> Sent from the Camel - Users mailing list archive at Nabble.com.