You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Gavin (JIRA)" <ji...@apache.org> on 2019/04/29 09:27:27 UTC

[jira] [Issue Comment Deleted] (MESOS-4231) Add a new category to cpplint to detect missing white-space in comments

     [ https://issues.apache.org/jira/browse/MESOS-4231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gavin updated MESOS-4231:
-------------------------
    Comment: was deleted

(was: www.rtat.net)

> Add a new category to cpplint to detect missing white-space in comments
> -----------------------------------------------------------------------
>
>                 Key: MESOS-4231
>                 URL: https://issues.apache.org/jira/browse/MESOS-4231
>             Project: Mesos
>          Issue Type: Improvement
>          Components: build
>            Reporter: Avinash Sridharan
>            Assignee: Avinash Sridharan
>            Priority: Minor
>              Labels: mesosphere
>             Fix For: 0.27.0
>
>
> Currently we haven't turned on any rule in cpplint.py to detect a missing leading whitespace in comments. Newbies tend to make this mistake even while trying to follow the style guide. 
> There is already a category in cpplint.py (whitespace/comments) to detect this, but it has the unfortunate side-affect of also tagging any trailing comments with less than 2 whitespaces between the code and the trailing comment as errors.  This side-affect generates a lot of false-positives since trailing comments in mesos codebase usually has only a single white-space. Hence proposing adding a new category called whitespace/mesos-comments that takes care of the more common case of tagging comments with leading whitespace as errors.   



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)