You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Dennis Lundberg (JIRA)" <ji...@codehaus.org> on 2006/12/31 00:39:09 UTC
[jira] Created: (DOXIA-87) Add support for class="externalLink" on
links in the same way that Maven 1 did
Add support for class="externalLink" on links in the same way that Maven 1 did
------------------------------------------------------------------------------
Key: DOXIA-87
URL: http://jira.codehaus.org/browse/DOXIA-87
Project: doxia
Issue Type: Improvement
Reporter: Dennis Lundberg
With Maven 1 sites you get these little small arrows right next to external links. It'd be nice if this was available in doxia and Maven 2 as well.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-87) Add support for class="externalLink"
on links in the same way that Maven 1 did
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-87?page=comments#action_84285 ]
Dennis Lundberg commented on DOXIA-87:
--------------------------------------
Having played with my patched version for a while now, I've discovered another bug. It turns out that maven-stylus-skin does not have an image for external links, yet it defines style rules for one in maven-theme.css, thus creating some space for the image to the right of the link. This didn't show before since Doxia didn't created the externalLink class.
> Add support for class="externalLink" on links in the same way that Maven 1 did
> ------------------------------------------------------------------------------
>
> Key: DOXIA-87
> URL: http://jira.codehaus.org/browse/DOXIA-87
> Project: doxia
> Issue Type: Improvement
> Components: Site Renderer, Core
> Reporter: Dennis Lundberg
> Attachments: DOXIA-87-core.patch, DOXIA-87-site-renderer.patch, screenshot-1.jpg
>
>
> With Maven 1 sites you get these little small arrows right next to external links. It'd be nice if this was available in doxia and Maven 2 as well.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DOXIA-87) Add support for class="externalLink" on
links in the same way that Maven 1 did
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-87?page=all ]
Dennis Lundberg updated DOXIA-87:
---------------------------------
Attachment: DOXIA-87-site-renderer.patch
Patch for site renderer. Introduces a little macro that does the externalLink handling for breadcrumbs, links and menu items.
> Add support for class="externalLink" on links in the same way that Maven 1 did
> ------------------------------------------------------------------------------
>
> Key: DOXIA-87
> URL: http://jira.codehaus.org/browse/DOXIA-87
> Project: doxia
> Issue Type: Improvement
> Reporter: Dennis Lundberg
> Attachments: DOXIA-87-site-renderer.patch
>
>
> With Maven 1 sites you get these little small arrows right next to external links. It'd be nice if this was available in doxia and Maven 2 as well.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DOXIA-87) Add support for class="externalLink" on
links in the same way that Maven 1 did
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-87?page=all ]
Dennis Lundberg updated DOXIA-87:
---------------------------------
Attachment: DOXIA-87-core.patch
Patch for doxia core. It adds class="externalLink" for external links in the document content in XhtmlSink.
Note that this patch involves the same code areas as my patch for DOXIA-85. Therefor this patch includes the patch for that issue as well. If the patch for DOXIA-85 is rejected, let me know and I'll create a new patch for this issue.
> Add support for class="externalLink" on links in the same way that Maven 1 did
> ------------------------------------------------------------------------------
>
> Key: DOXIA-87
> URL: http://jira.codehaus.org/browse/DOXIA-87
> Project: doxia
> Issue Type: Improvement
> Components: Site Renderer, Core
> Reporter: Dennis Lundberg
> Attachments: DOXIA-87-core.patch, DOXIA-87-site-renderer.patch
>
>
> With Maven 1 sites you get these little small arrows right next to external links. It'd be nice if this was available in doxia and Maven 2 as well.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DOXIA-87) Add support for class="externalLink" on
links in the same way that Maven 1 did
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-87?page=all ]
Dennis Lundberg updated DOXIA-87:
---------------------------------
Component/s: Site Renderer
Core
Patch attached: Yes
> Add support for class="externalLink" on links in the same way that Maven 1 did
> ------------------------------------------------------------------------------
>
> Key: DOXIA-87
> URL: http://jira.codehaus.org/browse/DOXIA-87
> Project: doxia
> Issue Type: Improvement
> Components: Site Renderer, Core
> Reporter: Dennis Lundberg
> Attachments: DOXIA-87-core.patch, DOXIA-87-site-renderer.patch
>
>
> With Maven 1 sites you get these little small arrows right next to external links. It'd be nice if this was available in doxia and Maven 2 as well.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-87) Add support for class="externalLink"
on links in the same way that Maven 1 did
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-87?page=comments#action_84296 ]
Brett Porter commented on DOXIA-87:
-----------------------------------
looks good. I'd suggest going ahead with the patch, and also releasing a new version of the stylus skin in advance to fix the problem.
> Add support for class="externalLink" on links in the same way that Maven 1 did
> ------------------------------------------------------------------------------
>
> Key: DOXIA-87
> URL: http://jira.codehaus.org/browse/DOXIA-87
> Project: doxia
> Issue Type: Improvement
> Components: Site Renderer, Core
> Reporter: Dennis Lundberg
> Attachments: DOXIA-87-core.patch, DOXIA-87-site-renderer.patch, screenshot-1.jpg
>
>
> With Maven 1 sites you get these little small arrows right next to external links. It'd be nice if this was available in doxia and Maven 2 as well.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (DOXIA-87) Add support for class="externalLink" on
links in the same way that Maven 1 did
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-87?page=all ]
Dennis Lundberg closed DOXIA-87.
--------------------------------
Assignee: Dennis Lundberg
Resolution: Fixed
Fix Version/s: 1.0
Patches have been applied.
> Add support for class="externalLink" on links in the same way that Maven 1 did
> ------------------------------------------------------------------------------
>
> Key: DOXIA-87
> URL: http://jira.codehaus.org/browse/DOXIA-87
> Project: doxia
> Issue Type: Improvement
> Components: Site Renderer, Core
> Reporter: Dennis Lundberg
> Assigned To: Dennis Lundberg
> Fix For: 1.0
>
> Attachments: DOXIA-87-core.patch, DOXIA-87-site-renderer.patch, screenshot-1.jpg
>
>
> With Maven 1 sites you get these little small arrows right next to external links. It'd be nice if this was available in doxia and Maven 2 as well.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DOXIA-87) Add support for class="externalLink" on
links in the same way that Maven 1 did
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-87?page=all ]
Dennis Lundberg updated DOXIA-87:
---------------------------------
Attachment: screenshot-1.jpg
This is what it look like. Check out the links under the banner.
> Add support for class="externalLink" on links in the same way that Maven 1 did
> ------------------------------------------------------------------------------
>
> Key: DOXIA-87
> URL: http://jira.codehaus.org/browse/DOXIA-87
> Project: doxia
> Issue Type: Improvement
> Components: Site Renderer, Core
> Reporter: Dennis Lundberg
> Attachments: DOXIA-87-core.patch, DOXIA-87-site-renderer.patch, screenshot-1.jpg
>
>
> With Maven 1 sites you get these little small arrows right next to external links. It'd be nice if this was available in doxia and Maven 2 as well.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira