[jira] Commented: (ZOOKEEPER-115) Potential NPE in QuorumCnxManager

["Patrick Hunt (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620749#action_12620749 ] 

Patrick Hunt commented on ZOOKEEPER-115:
----------------------------------------

jira chopped up the code snippet a bit.

Looks like this issue occurs in 2 places: ~line 217 and 331

hmm.... these two sections of code look suspiciously similar, refactoring opportunity? :-)

> Potential NPE in QuorumCnxManager
> ---------------------------------
>
>                 Key: ZOOKEEPER-115
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-115
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: quorum
>            Reporter: Patrick Hunt
>            Assignee: Flavio Paiva Junqueira
>
> Findbugs flagged this, notice that we are checking for null after using the reference.
>                if (senderWorkerMap.get(s.socket().getInetAddress()) != null) {
>                     senderWorkerMap.get(s.socket().getInetAddress()).finish();
>                 }
>                 /*
>                  * Start new worker thread with a clean state.
>                  */
>                 if (s != null) {

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.