You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Roman Coedo <no...@github.com> on 2014/06/18 01:39:59 UTC

[jclouds-labs-aws] JCLOUDS-457: Part of the code has been cleaned up (#15)

On the last commit we added TestUtils class. On this commit
the VaultNameValidator and the ThreeHashTest tests make use
of it.

GlacierClientMockTest was not using GlacierHeaders references.
This commit fixes this problem too.

In addition, the AWSRequestSignerV4, the TreeHash and the
VaultNameValidator classes are now final.
You can merge this Pull Request by running:

  git pull https://github.com/rcoedo/jclouds-labs-aws cleanup

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs-aws/pull/15

-- Commit Summary --

  * JCLOUDS-457: Part of the code has been cleaned up

-- File Changes --

    M glacier/src/main/java/org/jclouds/glacier/predicates/validators/VaultNameValidator.java (2)
    M glacier/src/main/java/org/jclouds/glacier/reference/GlacierHeaders.java (1)
    M glacier/src/main/java/org/jclouds/glacier/util/AWSRequestSignerV4.java (2)
    M glacier/src/main/java/org/jclouds/glacier/util/TreeHash.java (2)
    M glacier/src/test/java/org/jclouds/glacier/GlacierClientMockTest.java (45)
    M glacier/src/test/java/org/jclouds/glacier/predicates/validators/VaultNameValidatorTest.java (14)
    M glacier/src/test/java/org/jclouds/glacier/util/TreeHashTest.java (29)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-aws/pull/15.patch
https://github.com/jclouds/jclouds-labs-aws/pull/15.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/15

Re: [jclouds-labs-aws] JCLOUDS-457: Part of the code has been cleaned up (#15)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-labs-aws-pull-requests #32](https://jclouds.ci.cloudbees.com/job/jclouds-labs-aws-pull-requests/32/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/15#issuecomment-46380323

Re: [jclouds-labs-aws] JCLOUDS-457: Part of the code has been cleaned up (#15)

Posted by Andrew Gaul <no...@github.com>.

Closed #15.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/15#event-132437174

Re: [jclouds-labs-aws] JCLOUDS-457: Part of the code has been cleaned up (#15)

Posted by BuildHive <no...@github.com>.

[jclouds » jclouds-labs-aws #974](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-aws/974/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/15#issuecomment-46380201

Re: [jclouds-labs-aws] JCLOUDS-457: Part of the code has been cleaned up (#15)

Posted by Andrew Gaul <no...@github.com>.

Tested locally and pushed to master.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/15#issuecomment-46380019