You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "dlmarion (via GitHub)" <gi...@apache.org> on 2025/07/29 17:18:19 UTC
[PR] Fixed UpgradeIT [accumulo]
dlmarion opened a new pull request, #5768:
URL: https://github.com/apache/accumulo/pull/5768
Modified UpgradeIT to run test server implementations in their own thread. Also modified them to have their own ServerContext instead of sharing the one that Mini uses.
Closes #5767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed UpgradeIT [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #5768:
URL: https://github.com/apache/accumulo/pull/5768#discussion_r2240688224
##########
test/src/main/java/org/apache/accumulo/test/upgrade/UpgradeIT.java:
##########
@@ -139,14 +167,30 @@ public void testUpgradeManagerFailure() throws Exception {
ServerContext ctx = getCluster().getServerContext();
UpgradeUtilIT.downgradePersistentVersion(ctx);
- List<String> args = new ArrayList<>();
- args.add("--props");
- args.add(getCluster().getAccumuloPropertiesPath());
- try (TestManager mgr = new TestManager(args.toArray(new String[0]))) {
- IllegalStateException ise = assertThrows(IllegalStateException.class, () -> mgr.runServer());
- assertTrue(ise.getMessage().equals("Upgrade not started, " + Constants.ZUPGRADE_PROGRESS
- + " node does not exist. Did you run 'accumulo upgrade --start'?"));
- }
+ final AtomicReference<Throwable> err = new AtomicReference<>();
+ Thread testMgrThread = new Thread() {
+ @Override
+ public void run() {
+ try {
+ List<String> args = new ArrayList<>();
+ args.add("--props");
+ args.add(getCluster().getAccumuloPropertiesPath());
+ TestManager mgr = new TestManager(args.toArray(new String[0]));
+ mgr.runServer();
Review Comment:
Made a comment elsewhere about close and try w/ resources. Not sure why, but it seems like not calling close in try w/ resource and the change to a different server context avoid halting the test process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed UpgradeIT [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #5768:
URL: https://github.com/apache/accumulo/pull/5768#discussion_r2240684377
##########
test/src/main/java/org/apache/accumulo/test/upgrade/UpgradeIT.java:
##########
@@ -139,14 +167,30 @@ public void testUpgradeManagerFailure() throws Exception {
ServerContext ctx = getCluster().getServerContext();
UpgradeUtilIT.downgradePersistentVersion(ctx);
- List<String> args = new ArrayList<>();
- args.add("--props");
- args.add(getCluster().getAccumuloPropertiesPath());
- try (TestManager mgr = new TestManager(args.toArray(new String[0]))) {
- IllegalStateException ise = assertThrows(IllegalStateException.class, () -> mgr.runServer());
- assertTrue(ise.getMessage().equals("Upgrade not started, " + Constants.ZUPGRADE_PROGRESS
- + " node does not exist. Did you run 'accumulo upgrade --start'?"));
- }
+ final AtomicReference<Throwable> err = new AtomicReference<>();
+ Thread testMgrThread = new Thread() {
+ @Override
+ public void run() {
+ try {
+ List<String> args = new ArrayList<>();
+ args.add("--props");
+ args.add(getCluster().getAccumuloPropertiesPath());
+ TestManager mgr = new TestManager(args.toArray(new String[0]));
+ mgr.runServer();
+ mgr.close();
Review Comment:
mgr.close() will never be called when an exception is thrown from mgr.runServer(). Tried changing to the following the test fails w/ the process halting. Calling TestManager.close() seems to halt the test process.
```java
try(TestManager mgr = new TestManager(args.toArray(new String[0]))) {
mgr.runServer();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed UpgradeIT [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #5768:
URL: https://github.com/apache/accumulo/pull/5768#discussion_r2240569234
##########
test/src/main/java/org/apache/accumulo/test/upgrade/UpgradeIT.java:
##########
@@ -139,14 +167,30 @@ public void testUpgradeManagerFailure() throws Exception {
ServerContext ctx = getCluster().getServerContext();
UpgradeUtilIT.downgradePersistentVersion(ctx);
- List<String> args = new ArrayList<>();
- args.add("--props");
- args.add(getCluster().getAccumuloPropertiesPath());
- try (TestManager mgr = new TestManager(args.toArray(new String[0]))) {
- IllegalStateException ise = assertThrows(IllegalStateException.class, () -> mgr.runServer());
- assertTrue(ise.getMessage().equals("Upgrade not started, " + Constants.ZUPGRADE_PROGRESS
- + " node does not exist. Did you run 'accumulo upgrade --start'?"));
- }
+ final AtomicReference<Throwable> err = new AtomicReference<>();
+ Thread testMgrThread = new Thread() {
+ @Override
+ public void run() {
+ try {
+ List<String> args = new ArrayList<>();
+ args.add("--props");
+ args.add(getCluster().getAccumuloPropertiesPath());
+ TestManager mgr = new TestManager(args.toArray(new String[0]));
+ mgr.runServer();
Review Comment:
if the thread dies for some reason, then the test will fail instead of exiting like it's doing now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed UpgradeIT [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #5768:
URL: https://github.com/apache/accumulo/pull/5768#discussion_r2240688943
##########
test/src/main/java/org/apache/accumulo/test/upgrade/UpgradeIT.java:
##########
@@ -139,14 +167,30 @@ public void testUpgradeManagerFailure() throws Exception {
ServerContext ctx = getCluster().getServerContext();
UpgradeUtilIT.downgradePersistentVersion(ctx);
- List<String> args = new ArrayList<>();
- args.add("--props");
- args.add(getCluster().getAccumuloPropertiesPath());
- try (TestManager mgr = new TestManager(args.toArray(new String[0]))) {
- IllegalStateException ise = assertThrows(IllegalStateException.class, () -> mgr.runServer());
- assertTrue(ise.getMessage().equals("Upgrade not started, " + Constants.ZUPGRADE_PROGRESS
- + " node does not exist. Did you run 'accumulo upgrade --start'?"));
- }
+ final AtomicReference<Throwable> err = new AtomicReference<>();
+ Thread testMgrThread = new Thread() {
+ @Override
+ public void run() {
+ try {
+ List<String> args = new ArrayList<>();
+ args.add("--props");
+ args.add(getCluster().getAccumuloPropertiesPath());
+ TestManager mgr = new TestManager(args.toArray(new String[0]));
+ mgr.runServer();
Review Comment:
> I changed TestManager constructor back to the following locally super(new ConfigOpts(), (conf) -> getServerContext(), args) and ran these updated test and it still fails
I have reproduced this locally as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed UpgradeIT [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #5768:
URL: https://github.com/apache/accumulo/pull/5768#issuecomment-3136344733
In 840385e I reverted some of the prior changes. I think the major issues stem from the shared ServerContext object. The test passes with the current changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed UpgradeIT [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #5768:
URL: https://github.com/apache/accumulo/pull/5768#discussion_r2240709394
##########
test/src/main/java/org/apache/accumulo/test/upgrade/UpgradeIT.java:
##########
@@ -139,14 +167,30 @@ public void testUpgradeManagerFailure() throws Exception {
ServerContext ctx = getCluster().getServerContext();
UpgradeUtilIT.downgradePersistentVersion(ctx);
- List<String> args = new ArrayList<>();
- args.add("--props");
- args.add(getCluster().getAccumuloPropertiesPath());
- try (TestManager mgr = new TestManager(args.toArray(new String[0]))) {
- IllegalStateException ise = assertThrows(IllegalStateException.class, () -> mgr.runServer());
- assertTrue(ise.getMessage().equals("Upgrade not started, " + Constants.ZUPGRADE_PROGRESS
- + " node does not exist. Did you run 'accumulo upgrade --start'?"));
- }
+ final AtomicReference<Throwable> err = new AtomicReference<>();
+ Thread testMgrThread = new Thread() {
+ @Override
+ public void run() {
+ try {
+ List<String> args = new ArrayList<>();
+ args.add("--props");
+ args.add(getCluster().getAccumuloPropertiesPath());
+ TestManager mgr = new TestManager(args.toArray(new String[0]));
+ mgr.runServer();
+ mgr.close();
Review Comment:
We can remove the call to `mgr.close()` in these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed UpgradeIT [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion merged PR #5768:
URL: https://github.com/apache/accumulo/pull/5768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed UpgradeIT [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #5768:
URL: https://github.com/apache/accumulo/pull/5768#discussion_r2240596079
##########
test/src/main/java/org/apache/accumulo/test/upgrade/UpgradeIT.java:
##########
@@ -139,14 +167,30 @@ public void testUpgradeManagerFailure() throws Exception {
ServerContext ctx = getCluster().getServerContext();
UpgradeUtilIT.downgradePersistentVersion(ctx);
- List<String> args = new ArrayList<>();
- args.add("--props");
- args.add(getCluster().getAccumuloPropertiesPath());
- try (TestManager mgr = new TestManager(args.toArray(new String[0]))) {
- IllegalStateException ise = assertThrows(IllegalStateException.class, () -> mgr.runServer());
- assertTrue(ise.getMessage().equals("Upgrade not started, " + Constants.ZUPGRADE_PROGRESS
- + " node does not exist. Did you run 'accumulo upgrade --start'?"));
- }
+ final AtomicReference<Throwable> err = new AtomicReference<>();
+ Thread testMgrThread = new Thread() {
+ @Override
+ public void run() {
+ try {
+ List<String> args = new ArrayList<>();
+ args.add("--props");
+ args.add(getCluster().getAccumuloPropertiesPath());
+ TestManager mgr = new TestManager(args.toArray(new String[0]));
+ mgr.runServer();
Review Comment:
The test was failing before because something was deleting the manager lock and that caused the process to halt. I think the thread running this test thread was fine. I changed TestManager constructor back to the following locally `super(new ConfigOpts(), (conf) -> getServerContext(), args)` and ran these updated test and it still fails because something halts the process. So it seems that making that change to server context fixes the test, but I do not understand why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed UpgradeIT [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #5768:
URL: https://github.com/apache/accumulo/pull/5768#discussion_r2240707623
##########
test/src/main/java/org/apache/accumulo/test/upgrade/UpgradeIT.java:
##########
@@ -139,14 +167,30 @@ public void testUpgradeManagerFailure() throws Exception {
ServerContext ctx = getCluster().getServerContext();
UpgradeUtilIT.downgradePersistentVersion(ctx);
- List<String> args = new ArrayList<>();
- args.add("--props");
- args.add(getCluster().getAccumuloPropertiesPath());
- try (TestManager mgr = new TestManager(args.toArray(new String[0]))) {
- IllegalStateException ise = assertThrows(IllegalStateException.class, () -> mgr.runServer());
- assertTrue(ise.getMessage().equals("Upgrade not started, " + Constants.ZUPGRADE_PROGRESS
- + " node does not exist. Did you run 'accumulo upgrade --start'?"));
- }
+ final AtomicReference<Throwable> err = new AtomicReference<>();
+ Thread testMgrThread = new Thread() {
+ @Override
+ public void run() {
+ try {
+ List<String> args = new ArrayList<>();
+ args.add("--props");
+ args.add(getCluster().getAccumuloPropertiesPath());
+ TestManager mgr = new TestManager(args.toArray(new String[0]));
+ mgr.runServer();
Review Comment:
I suspect the thread code could be removed, simplifying the test. Assuming the test thread called something that halted the process. If there is an uncaught exception from the test, junit code should catch that and handle in its normal way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed UpgradeIT [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #5768:
URL: https://github.com/apache/accumulo/pull/5768#discussion_r2240560956
##########
test/src/main/java/org/apache/accumulo/test/upgrade/UpgradeIT.java:
##########
@@ -139,14 +167,30 @@ public void testUpgradeManagerFailure() throws Exception {
ServerContext ctx = getCluster().getServerContext();
UpgradeUtilIT.downgradePersistentVersion(ctx);
- List<String> args = new ArrayList<>();
- args.add("--props");
- args.add(getCluster().getAccumuloPropertiesPath());
- try (TestManager mgr = new TestManager(args.toArray(new String[0]))) {
- IllegalStateException ise = assertThrows(IllegalStateException.class, () -> mgr.runServer());
- assertTrue(ise.getMessage().equals("Upgrade not started, " + Constants.ZUPGRADE_PROGRESS
- + " node does not exist. Did you run 'accumulo upgrade --start'?"));
- }
+ final AtomicReference<Throwable> err = new AtomicReference<>();
+ Thread testMgrThread = new Thread() {
+ @Override
+ public void run() {
+ try {
+ List<String> args = new ArrayList<>();
+ args.add("--props");
+ args.add(getCluster().getAccumuloPropertiesPath());
+ TestManager mgr = new TestManager(args.toArray(new String[0]));
+ mgr.runServer();
Review Comment:
What is the benefit of calling this code in another thread?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed UpgradeIT [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #5768:
URL: https://github.com/apache/accumulo/pull/5768#discussion_r2240589783
##########
test/src/main/java/org/apache/accumulo/test/upgrade/UpgradeIT.java:
##########
@@ -139,14 +167,30 @@ public void testUpgradeManagerFailure() throws Exception {
ServerContext ctx = getCluster().getServerContext();
UpgradeUtilIT.downgradePersistentVersion(ctx);
- List<String> args = new ArrayList<>();
- args.add("--props");
- args.add(getCluster().getAccumuloPropertiesPath());
- try (TestManager mgr = new TestManager(args.toArray(new String[0]))) {
- IllegalStateException ise = assertThrows(IllegalStateException.class, () -> mgr.runServer());
- assertTrue(ise.getMessage().equals("Upgrade not started, " + Constants.ZUPGRADE_PROGRESS
- + " node does not exist. Did you run 'accumulo upgrade --start'?"));
- }
+ final AtomicReference<Throwable> err = new AtomicReference<>();
+ Thread testMgrThread = new Thread() {
+ @Override
+ public void run() {
+ try {
+ List<String> args = new ArrayList<>();
+ args.add("--props");
+ args.add(getCluster().getAccumuloPropertiesPath());
+ TestManager mgr = new TestManager(args.toArray(new String[0]));
+ mgr.runServer();
Review Comment:
Also, the old code was part of the problem. Using a new ServerContext was not enough by itself. Using the old code here causes the test class to exit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed UpgradeIT [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #5768:
URL: https://github.com/apache/accumulo/pull/5768#discussion_r2240684377
##########
test/src/main/java/org/apache/accumulo/test/upgrade/UpgradeIT.java:
##########
@@ -139,14 +167,30 @@ public void testUpgradeManagerFailure() throws Exception {
ServerContext ctx = getCluster().getServerContext();
UpgradeUtilIT.downgradePersistentVersion(ctx);
- List<String> args = new ArrayList<>();
- args.add("--props");
- args.add(getCluster().getAccumuloPropertiesPath());
- try (TestManager mgr = new TestManager(args.toArray(new String[0]))) {
- IllegalStateException ise = assertThrows(IllegalStateException.class, () -> mgr.runServer());
- assertTrue(ise.getMessage().equals("Upgrade not started, " + Constants.ZUPGRADE_PROGRESS
- + " node does not exist. Did you run 'accumulo upgrade --start'?"));
- }
+ final AtomicReference<Throwable> err = new AtomicReference<>();
+ Thread testMgrThread = new Thread() {
+ @Override
+ public void run() {
+ try {
+ List<String> args = new ArrayList<>();
+ args.add("--props");
+ args.add(getCluster().getAccumuloPropertiesPath());
+ TestManager mgr = new TestManager(args.toArray(new String[0]));
+ mgr.runServer();
+ mgr.close();
Review Comment:
mgr.close() will never be called when an excepting is thrown from mgr.runServer(). Tried changing to the following the test fails w/ the process halting. Calling TestManager.close() seems to halt the test process.
```java
try(TestManager mgr = new TestManager(args.toArray(new String[0]))) {
mgr.runServer();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed UpgradeIT [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #5768:
URL: https://github.com/apache/accumulo/pull/5768#discussion_r2240684377
##########
test/src/main/java/org/apache/accumulo/test/upgrade/UpgradeIT.java:
##########
@@ -139,14 +167,30 @@ public void testUpgradeManagerFailure() throws Exception {
ServerContext ctx = getCluster().getServerContext();
UpgradeUtilIT.downgradePersistentVersion(ctx);
- List<String> args = new ArrayList<>();
- args.add("--props");
- args.add(getCluster().getAccumuloPropertiesPath());
- try (TestManager mgr = new TestManager(args.toArray(new String[0]))) {
- IllegalStateException ise = assertThrows(IllegalStateException.class, () -> mgr.runServer());
- assertTrue(ise.getMessage().equals("Upgrade not started, " + Constants.ZUPGRADE_PROGRESS
- + " node does not exist. Did you run 'accumulo upgrade --start'?"));
- }
+ final AtomicReference<Throwable> err = new AtomicReference<>();
+ Thread testMgrThread = new Thread() {
+ @Override
+ public void run() {
+ try {
+ List<String> args = new ArrayList<>();
+ args.add("--props");
+ args.add(getCluster().getAccumuloPropertiesPath());
+ TestManager mgr = new TestManager(args.toArray(new String[0]));
+ mgr.runServer();
+ mgr.close();
Review Comment:
mgr.close() will never be called when an exception is thrown from mgr.runServer(). Tried changing to the following snd the test fails w/ the process halting. Calling TestManager.close() seems to halt the test process.
```java
try(TestManager mgr = new TestManager(args.toArray(new String[0]))) {
mgr.runServer();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed UpgradeIT [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #5768:
URL: https://github.com/apache/accumulo/pull/5768#issuecomment-3136103824
I'm still digging into why / where the lock for the TestManager class is being removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed UpgradeIT [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #5768:
URL: https://github.com/apache/accumulo/pull/5768#discussion_r2240684377
##########
test/src/main/java/org/apache/accumulo/test/upgrade/UpgradeIT.java:
##########
@@ -139,14 +167,30 @@ public void testUpgradeManagerFailure() throws Exception {
ServerContext ctx = getCluster().getServerContext();
UpgradeUtilIT.downgradePersistentVersion(ctx);
- List<String> args = new ArrayList<>();
- args.add("--props");
- args.add(getCluster().getAccumuloPropertiesPath());
- try (TestManager mgr = new TestManager(args.toArray(new String[0]))) {
- IllegalStateException ise = assertThrows(IllegalStateException.class, () -> mgr.runServer());
- assertTrue(ise.getMessage().equals("Upgrade not started, " + Constants.ZUPGRADE_PROGRESS
- + " node does not exist. Did you run 'accumulo upgrade --start'?"));
- }
+ final AtomicReference<Throwable> err = new AtomicReference<>();
+ Thread testMgrThread = new Thread() {
+ @Override
+ public void run() {
+ try {
+ List<String> args = new ArrayList<>();
+ args.add("--props");
+ args.add(getCluster().getAccumuloPropertiesPath());
+ TestManager mgr = new TestManager(args.toArray(new String[0]));
+ mgr.runServer();
+ mgr.close();
Review Comment:
mgr.close() will never be called when an exception is thrown from mgr.runServer(). Tried changing to the following and the test fails w/ the process halting. Calling TestManager.close() seems to halt the test process.
```java
try(TestManager mgr = new TestManager(args.toArray(new String[0]))) {
mgr.runServer();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org