You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/08/02 22:49:33 UTC

[GitHub] [kafka] guozhangwang commented on pull request #9102: KAFKA-10326 Both serializer and deserializer should be able to see th…

guozhangwang commented on pull request #9102:
URL: https://github.com/apache/kafka/pull/9102#issuecomment-667734629


   This change makes sense to me, thanks @chia7712 
   
   One (very) minor thing is that, `enableAutoCommit` may also be overridden when passing into the coordinator object, i.e. the value read from ConsumerConfig may be different from what's actually used. I'm not too worry that this would be leveraged by serde but just want to bring this up.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org