You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/01/16 08:22:08 UTC
[GitHub] [camel-quarkus] jamesnetherton opened a new pull request #625: Add
ahc-ws extension
jamesnetherton opened a new pull request #625: Add ahc-ws extension
URL: https://github.com/apache/camel-quarkus/pull/625
fixes #619
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull
request #625: Add ahc-ws extension
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #625: Add ahc-ws extension
URL: https://github.com/apache/camel-quarkus/pull/625#discussion_r367371136
##########
File path: extensions/ahc-ws/runtime/pom.xml
##########
@@ -0,0 +1,86 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-ahc-ws-parent</artifactId>
+ <version>1.1.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
+ </parent>
+
+ <artifactId>camel-quarkus-ahc-ws</artifactId>
+ <name>Camel Quarkus :: AHC-WS :: Runtime</name>
+
+ <properties>
+ <firstVersion>1.2.0</firstVersion>
+ </properties>
+
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-bom</artifactId>
+ <version>${project.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
+ </dependencies>
+ </dependencyManagement>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-core</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-http-common</artifactId>
+ </dependency>
+ <dependency>
Review comment:
Added `camel-quarkus-support-ahc` to runtime.
`camel-quarkus-http-common` was actually a leftover from some early experiments. It's removed now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #625:
Add ahc-ws extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #625: Add ahc-ws extension
URL: https://github.com/apache/camel-quarkus/pull/625#discussion_r367345248
##########
File path: extensions/ahc-ws/runtime/pom.xml
##########
@@ -0,0 +1,86 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-ahc-ws-parent</artifactId>
+ <version>1.1.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
+ </parent>
+
+ <artifactId>camel-quarkus-ahc-ws</artifactId>
+ <name>Camel Quarkus :: AHC-WS :: Runtime</name>
+
+ <properties>
+ <firstVersion>1.2.0</firstVersion>
+ </properties>
+
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-bom</artifactId>
+ <version>${project.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
+ </dependencies>
+ </dependencyManagement>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-core</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-http-common</artifactId>
+ </dependency>
+ <dependency>
Review comment:
The deployment dependencies should typically match runtime dependencies. There are some discrepancies:
* camel-quarkus-support-ahc missing here in runtime
* camel-quarkus-http-common-deployment missing in the deployment module
Are there any reasons for that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #625: Add ahc-ws
extension
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #625: Add ahc-ws extension
URL: https://github.com/apache/camel-quarkus/pull/625#issuecomment-577408807
the pr build has been aborted because of timeout while testing examples and no test were in error, going to merge it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull
request #625: Add ahc-ws extension
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #625: Add ahc-ws extension
URL: https://github.com/apache/camel-quarkus/pull/625#discussion_r367371668
##########
File path: extensions/ahc-ws/runtime/src/main/resources/META-INF/quarkus-extension.yaml
##########
@@ -0,0 +1,32 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+---
+name: "Camel Quarkus Async HTTP Client (AHC) Web Socket"
+description: "Camel Quarkus Async HTTP Client (AHC) Web Socket support"
+metadata:
+ keywords:
+ - "camel"
+ - "http"
+ - "websocket"
+ - "websockets"
+ - "web-socket"
+ - "web-sockets"
Review comment:
It's a lazy copy / paste from the Quarkus Undertow Websocket extension. If we really want to trim down this list, I can do follow up PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #625: Add ahc-ws
extension
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #625: Add ahc-ws extension
URL: https://github.com/apache/camel-quarkus/pull/625#issuecomment-576870864
@jamesnetherton do you mind rebase so we can test against quarkus 1.2.0 RC ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli merged pull request #625: Add ahc-ws
extension
Posted by GitBox <gi...@apache.org>.
lburgazzoli merged pull request #625: Add ahc-ws extension
URL: https://github.com/apache/camel-quarkus/pull/625
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #625:
Add ahc-ws extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #625: Add ahc-ws extension
URL: https://github.com/apache/camel-quarkus/pull/625#discussion_r367379692
##########
File path: extensions/ahc-ws/runtime/src/main/resources/META-INF/quarkus-extension.yaml
##########
@@ -0,0 +1,32 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+---
+name: "Camel Quarkus Async HTTP Client (AHC) Web Socket"
+description: "Camel Quarkus Async HTTP Client (AHC) Web Socket support"
+metadata:
+ keywords:
+ - "camel"
+ - "http"
+ - "websocket"
+ - "websockets"
+ - "web-socket"
+ - "web-sockets"
Review comment:
Not a big issue, but I'd vote for reducing the list unless we know the expanded list solves some problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton commented on issue #625: Add ahc-ws
extension
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on issue #625: Add ahc-ws extension
URL: https://github.com/apache/camel-quarkus/pull/625#issuecomment-575045609
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull
request #625: Add ahc-ws extension
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #625: Add ahc-ws extension
URL: https://github.com/apache/camel-quarkus/pull/625#discussion_r367375132
##########
File path: extensions/ahc-ws/runtime/pom.xml
##########
@@ -0,0 +1,86 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-ahc-ws-parent</artifactId>
+ <version>1.1.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
+ </parent>
+
+ <artifactId>camel-quarkus-ahc-ws</artifactId>
+ <name>Camel Quarkus :: AHC-WS :: Runtime</name>
+
+ <properties>
+ <firstVersion>1.2.0</firstVersion>
+ </properties>
+
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-bom</artifactId>
+ <version>${project.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
+ </dependencies>
+ </dependencyManagement>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-core</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-http-common</artifactId>
+ </dependency>
+ <dependency>
Review comment:
Scratch that last comment about http-common. It should be present. So I'll fix that up too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton commented on issue #625: Add ahc-ws
extension
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on issue #625: Add ahc-ws extension
URL: https://github.com/apache/camel-quarkus/pull/625#issuecomment-577045114
Rebased
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] gsmet commented on issue #625: Add ahc-ws extension
Posted by GitBox <gi...@apache.org>.
gsmet commented on issue #625: Add ahc-ws extension
URL: https://github.com/apache/camel-quarkus/pull/625#issuecomment-575114398
Could you please hold on on adding more extensions until the next release (that should start at the end of next week)?
We struggle to get the current extensions working with GraalVM 19.3.1 so adding more won't help.
Thanks!
/cc @lburgazzoli
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #625:
Add ahc-ws extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #625: Add ahc-ws extension
URL: https://github.com/apache/camel-quarkus/pull/625#discussion_r367347281
##########
File path: extensions/ahc-ws/runtime/src/main/resources/META-INF/quarkus-extension.yaml
##########
@@ -0,0 +1,32 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+---
+name: "Camel Quarkus Async HTTP Client (AHC) Web Socket"
+description: "Camel Quarkus Async HTTP Client (AHC) Web Socket support"
+metadata:
+ keywords:
+ - "camel"
+ - "http"
+ - "websocket"
+ - "websockets"
+ - "web-socket"
+ - "web-sockets"
Review comment:
Is there something that would break without having all these spelling variants here? (Should we start doing it everywhere?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton commented on issue #625: Add ahc-ws
extension
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on issue #625: Add ahc-ws extension
URL: https://github.com/apache/camel-quarkus/pull/625#issuecomment-577053119
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services