You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "wasabii (via GitHub)" <gi...@apache.org> on 2026/09/08 00:35:43 UTC
[PR] [CALCITE-7768] SqlDialect has no way to unparse a UUID literal [calcite]
wasabii opened a new pull request, #5250:
URL: https://github.com/apache/calcite/pull/5250
## Jira Link
[CALCITE-7768](https://issues.apache.org/jira/browse/CALCITE-7768)
## Changes Proposed
A dialect can now decide how a UUID literal is written. The default output is unchanged, so only MSSQL is affected: it writes a plain quoted string, which SQL Server accepts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7768] SqlDialect has no way to unparse a UUID literal [calcite]
Posted by "wasabii (via GitHub)" <gi...@apache.org>.
wasabii commented on code in PR #5250:
URL: https://github.com/apache/calcite/pull/5250#discussion_r3953775110
##########
core/src/main/java/org/apache/calcite/sql/SqlDialect.java:
##########
@@ -579,6 +579,11 @@ public void unparseTableScanHints(SqlWriter writer,
SqlNodeList hints, int leftPrec, int rightPrec) {
}
+ public void unparseUuidLiteral(SqlWriter writer,
+ SqlUuidLiteral literal, int leftPrec, int rightPrec) {
+ writer.literal(literal.toString());
Review Comment:
Im not aware of any real database that uses the Calcite syntax. So the default is kinda useless. But that is the Calcite syntax.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7768] SqlDialect has no way to unparse a UUID literal [calcite]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu merged PR #5250:
URL: https://github.com/apache/calcite/pull/5250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7768] SqlDialect has no way to unparse a UUID literal [calcite]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on code in PR #5250:
URL: https://github.com/apache/calcite/pull/5250#discussion_r3954893379
##########
core/src/main/java/org/apache/calcite/sql/SqlDialect.java:
##########
@@ -579,6 +579,11 @@ public void unparseTableScanHints(SqlWriter writer,
SqlNodeList hints, int leftPrec, int rightPrec) {
}
+ public void unparseUuidLiteral(SqlWriter writer,
+ SqlUuidLiteral literal, int leftPrec, int rightPrec) {
+ writer.literal(literal.toString());
Review Comment:
Could you add a test for this default Calcite method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7768] SqlDialect has no way to unparse a UUID literal [calcite]
Posted by "wasabii (via GitHub)" <gi...@apache.org>.
wasabii commented on code in PR #5250:
URL: https://github.com/apache/calcite/pull/5250#discussion_r3996328646
##########
core/src/main/java/org/apache/calcite/sql/SqlDialect.java:
##########
@@ -579,6 +579,11 @@ public void unparseTableScanHints(SqlWriter writer,
SqlNodeList hints, int leftPrec, int rightPrec) {
}
+ public void unparseUuidLiteral(SqlWriter writer,
+ SqlUuidLiteral literal, int leftPrec, int rightPrec) {
+ writer.literal(literal.toString());
Review Comment:
There already is one I believe. Was there before me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7768] SqlDialect has no way to unparse a UUID literal [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #5250:
URL: https://github.com/apache/calcite/pull/5250#issuecomment-5631295761
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=5250) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=5250&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=5250&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=5250&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=5250&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=5250&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=5250)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7768] SqlDialect has no way to unparse a UUID literal [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #5250:
URL: https://github.com/apache/calcite/pull/5250#issuecomment-5577447621
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=5250) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=5250&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=5250&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=5250&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=5250&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=5250&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=5250)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7768] SqlDialect has no way to unparse a UUID literal [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on PR #5250:
URL: https://github.com/apache/calcite/pull/5250#issuecomment-5672910138
Can this PR be approved and merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7768] SqlDialect has no way to unparse a UUID literal [calcite]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on code in PR #5250:
URL: https://github.com/apache/calcite/pull/5250#discussion_r3953721907
##########
core/src/main/java/org/apache/calcite/sql/SqlDialect.java:
##########
@@ -579,6 +579,11 @@ public void unparseTableScanHints(SqlWriter writer,
SqlNodeList hints, int leftPrec, int rightPrec) {
}
+ public void unparseUuidLiteral(SqlWriter writer,
+ SqlUuidLiteral literal, int leftPrec, int rightPrec) {
+ writer.literal(literal.toString());
Review Comment:
Should this default implementation align with MySQL or PostgreSQL? Should we choose a generic approach, or simply throw an error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7768] SqlDialect has no way to unparse a UUID literal [calcite]
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on code in PR #5250:
URL: https://github.com/apache/calcite/pull/5250#discussion_r3968044537
##########
core/src/main/java/org/apache/calcite/sql/SqlDialect.java:
##########
@@ -579,6 +579,11 @@ public void unparseTableScanHints(SqlWriter writer,
SqlNodeList hints, int leftPrec, int rightPrec) {
}
+ public void unparseUuidLiteral(SqlWriter writer,
Review Comment:
Suggest adding a Javadoc here; this is a public extension point intended for developers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org