You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/05/01 19:10:29 UTC

[GitHub] [shardingsphere] terrymanu opened a new pull request #10238: Add parameterValueLength for PostgreSQLBinaryProtocolValue

terrymanu opened a new pull request #10238:
URL: https://github.com/apache/shardingsphere/pull/10238


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10238: Add parameterValueLength for PostgreSQLBinaryProtocolValue

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10238:
URL: https://github.com/apache/shardingsphere/pull/10238#issuecomment-830684473


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10238?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#10238](https://codecov.io/gh/apache/shardingsphere/pull/10238?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (81e7a58) into [master](https://codecov.io/gh/apache/shardingsphere/commit/6e3458eda6daab54143ad794c3b1ad04f7ed95b0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6e3458e) will **decrease** coverage by `0.11%`.
   > The diff coverage is `53.12%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/10238/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/10238?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #10238      +/-   ##
   ============================================
   - Coverage     68.00%   67.89%   -0.12%     
     Complexity      684      684              
   ============================================
     Files          1703     1703              
     Lines         29187    29192       +5     
     Branches       5234     5253      +19     
   ============================================
   - Hits          19850    19819      -31     
   - Misses         7811     7844      +33     
   - Partials       1526     1529       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/10238?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...nd/protocol/PostgreSQLDateBinaryProtocolValue.java](https://codecov.io/gh/apache/shardingsphere/pull/10238/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvY29tbWFuZC9xdWVyeS9iaW5hcnkvYmluZC9wcm90b2NvbC9Qb3N0Z3JlU1FMRGF0ZUJpbmFyeVByb3RvY29sVmFsdWUuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...d/protocol/PostgreSQLFloatBinaryProtocolValue.java](https://codecov.io/gh/apache/shardingsphere/pull/10238/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvY29tbWFuZC9xdWVyeS9iaW5hcnkvYmluZC9wcm90b2NvbC9Qb3N0Z3JlU1FMRmxvYXRCaW5hcnlQcm90b2NvbFZhbHVlLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...nd/protocol/PostgreSQLTimeBinaryProtocolValue.java](https://codecov.io/gh/apache/shardingsphere/pull/10238/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvY29tbWFuZC9xdWVyeS9iaW5hcnkvYmluZC9wcm90b2NvbC9Qb3N0Z3JlU1FMVGltZUJpbmFyeVByb3RvY29sVmFsdWUuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...nd/protocol/PostgreSQLInt4BinaryProtocolValue.java](https://codecov.io/gh/apache/shardingsphere/pull/10238/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvY29tbWFuZC9xdWVyeS9iaW5hcnkvYmluZC9wcm90b2NvbC9Qb3N0Z3JlU1FMSW50NEJpbmFyeVByb3RvY29sVmFsdWUuamF2YQ==) | `55.55% <20.00%> (-44.45%)` | `1.00 <0.00> (ø)` | |
   | [.../protocol/PostgreSQLDoubleBinaryProtocolValue.java](https://codecov.io/gh/apache/shardingsphere/pull/10238/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvY29tbWFuZC9xdWVyeS9iaW5hcnkvYmluZC9wcm90b2NvbC9Qb3N0Z3JlU1FMRG91YmxlQmluYXJ5UHJvdG9jb2xWYWx1ZS5qYXZh) | `62.50% <25.00%> (-37.50%)` | `1.00 <0.00> (ø)` | |
   | [...nd/protocol/PostgreSQLInt2BinaryProtocolValue.java](https://codecov.io/gh/apache/shardingsphere/pull/10238/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvY29tbWFuZC9xdWVyeS9iaW5hcnkvYmluZC9wcm90b2NvbC9Qb3N0Z3JlU1FMSW50MkJpbmFyeVByb3RvY29sVmFsdWUuamF2YQ==) | `62.50% <25.00%> (-37.50%)` | `1.00 <0.00> (ø)` | |
   | [...nd/protocol/PostgreSQLInt8BinaryProtocolValue.java](https://codecov.io/gh/apache/shardingsphere/pull/10238/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvY29tbWFuZC9xdWVyeS9iaW5hcnkvYmluZC9wcm90b2NvbC9Qb3N0Z3JlU1FMSW50OEJpbmFyeVByb3RvY29sVmFsdWUuamF2YQ==) | `50.00% <33.33%> (-30.00%)` | `1.00 <0.00> (ø)` | |
   | [...and/query/binary/bind/PostgreSQLComBindPacket.java](https://codecov.io/gh/apache/shardingsphere/pull/10238/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvY29tbWFuZC9xdWVyeS9iaW5hcnkvYmluZC9Qb3N0Z3JlU1FMQ29tQmluZFBhY2tldC5qYXZh) | `85.71% <66.66%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...otocol/PostgreSQLBoolArrayBinaryProtocolValue.java](https://codecov.io/gh/apache/shardingsphere/pull/10238/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvY29tbWFuZC9xdWVyeS9iaW5hcnkvYmluZC9wcm90b2NvbC9Qb3N0Z3JlU1FMQm9vbEFycmF5QmluYXJ5UHJvdG9jb2xWYWx1ZS5qYXZh) | `85.71% <100.00%> (-1.79%)` | `1.00 <0.00> (ø)` | |
   | [...ocol/PostgreSQLFloat4ArrayBinaryProtocolValue.java](https://codecov.io/gh/apache/shardingsphere/pull/10238/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvY29tbWFuZC9xdWVyeS9iaW5hcnkvYmluZC9wcm90b2NvbC9Qb3N0Z3JlU1FMRmxvYXQ0QXJyYXlCaW5hcnlQcm90b2NvbFZhbHVlLmphdmE=) | `85.71% <100.00%> (-1.79%)` | `1.00 <0.00> (ø)` | |
   | ... and [12 more](https://codecov.io/gh/apache/shardingsphere/pull/10238/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10238?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10238?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6e3458e...81e7a58](https://codecov.io/gh/apache/shardingsphere/pull/10238?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on pull request #10238: Add parameterValueLength for PostgreSQLBinaryProtocolValue

Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #10238:
URL: https://github.com/apache/shardingsphere/pull/10238#issuecomment-830740710


   > The client send a 3-byte integer and `UnsupportedOperationException` occurred.
   
   The exception comes from text format, I will fix it at next pr


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TeslaCN commented on pull request #10238: Add parameterValueLength for PostgreSQLBinaryProtocolValue

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on pull request #10238:
URL: https://github.com/apache/shardingsphere/pull/10238#issuecomment-830730635


   ![image](https://user-images.githubusercontent.com/20503072/116800433-a2ec2980-ab33-11eb-896f-64e1b0666d79.png)
   
   ![image](https://user-images.githubusercontent.com/20503072/116800442-b9928080-ab33-11eb-81a0-6257ece5758b.png)
   
   ```
   [ERROR] 10:44:46.735 [pool-11-thread-1] o.a.s.p.f.c.CommandExecutorTask - Exception occur: 
   java.lang.UnsupportedOperationException: paramValueLength 3
   	at org.apache.shardingsphere.db.protocol.postgresql.packet.command.query.binary.bind.protocol.PostgreSQLInt8BinaryProtocolValue.read(PostgreSQLInt8BinaryProtocolValue.java:46)
   	at org.apache.shardingsphere.db.protocol.postgresql.packet.command.query.binary.bind.PostgreSQLComBindPacket.getParameters(PostgreSQLComBindPacket.java:77)
   	at org.apache.shardingsphere.db.protocol.postgresql.packet.command.query.binary.bind.PostgreSQLComBindPacket.<init>(PostgreSQLComBindPacket.java:59)
   	at org.apache.shardingsphere.db.protocol.postgresql.packet.command.PostgreSQLCommandPacketFactory.newInstance(PostgreSQLCommandPacketFactory.java:53)
   	at org.apache.shardingsphere.proxy.frontend.postgresql.command.PostgreSQLCommandExecuteEngine.getCommandPacket(PostgreSQLCommandExecuteEngine.java:56)
   	at org.apache.shardingsphere.proxy.frontend.postgresql.command.PostgreSQLCommandExecuteEngine.getCommandPacket(PostgreSQLCommandExecuteEngine.java:47)
   	at org.apache.shardingsphere.proxy.frontend.command.CommandExecutorTask.executeCommand(CommandExecutorTask.java:92)
   	at org.apache.shardingsphere.proxy.frontend.command.CommandExecutorTask.run(CommandExecutorTask.java:71)
   	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
   	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
   	at java.lang.Thread.run(Thread.java:748)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TeslaCN merged pull request #10238: Add parameterValueLength for PostgreSQLBinaryProtocolValue

Posted by GitBox <gi...@apache.org>.
TeslaCN merged pull request #10238:
URL: https://github.com/apache/shardingsphere/pull/10238


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org