You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/08/25 06:01:54 UTC
[GitHub] [spark] panbingkun opened a new pull request, #42673: [SPARK-44959][BUILD] Upgrade sbt to 1.9.4
panbingkun opened a new pull request, #42673:
URL: https://github.com/apache/spark/pull/42673
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #42673: [SPARK-44959][BUILD] Upgrade sbt to 1.9.5
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42673:
URL: https://github.com/apache/spark/pull/42673#issuecomment-1733011847
> could you rebase this one ? @panbingkun
I have submitted a test on the latest master, but unfortunately it still has issues. I have identified the issue, but I need some time to see how to fix it reasonably.
https://github.com/panbingkun/spark/actions/runs/6294142093/job/17087611901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #42673: [SPARK-44959][BUILD] Upgrade sbt to 1.9.4
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42673:
URL: https://github.com/apache/spark/pull/42673#issuecomment-1693026518
> no problem with the local build, I think you can try again. @panbingkun
But I also had a similar issue with the local run, let me investigate it first.
<img width="1323" alt="fc5abb533c56415876c10eb72760520f" src="https://github.com/apache/spark/assets/15246973/394d21d1-7276-4e03-ba98-e5425d6a44be">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #42673: [SPARK-44959][BUILD] Upgrade sbt to 1.9.4
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42673:
URL: https://github.com/apache/spark/pull/42673#issuecomment-1693042344
It should be a cache issue with the Courier. When I delete `4.1.96.Final` from the local mvn report and execute it again, the error disappears.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42673: [SPARK-44959][BUILD] Upgrade sbt to 1.9.4
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42673:
URL: https://github.com/apache/spark/pull/42673#issuecomment-1699415059
For #42733 , I have a question.
- https://github.com/apache/spark/pull/42733#pullrequestreview-1602993100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #42673: [SPARK-44959][BUILD] Upgrade sbt to 1.9.4
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42673:
URL: https://github.com/apache/spark/pull/42673#issuecomment-1694056937
Yeah, Let me continue investigating it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #42673: [SPARK-44959][BUILD] Upgrade sbt to 1.9.5
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42673:
URL: https://github.com/apache/spark/pull/42673#issuecomment-1733097199
> https://github.com/panbingkun/spark/actions/runs/6294142093/job/17087611901
Its root cause is that if there is a corrupted jar in Maven's repo, the above problem will occur. Currently, the possible solutions to bypass it are
1.Before run, delete all Maven's repos
2.Adjust the cache policy of the courier
Yes, it all affects run time to some extent. Currently, what I am looking for is a solution that does not affect run time, give me some time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44959][BUILD] Upgrade sbt to 1.9.5 [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #42673: [SPARK-44959][BUILD] Upgrade sbt to 1.9.5
URL: https://github.com/apache/spark/pull/42673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42673: [SPARK-44959][BUILD] Upgrade sbt to 1.9.4
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42673:
URL: https://github.com/apache/spark/pull/42673#issuecomment-1694553868
Thank you for retry. It seems that Scala 2.13 SBT still fails with `useCoursier := false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #42673: [SPARK-44959][BUILD] Upgrade sbt to 1.9.4
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #42673:
URL: https://github.com/apache/spark/pull/42673#discussion_r1306613468
##########
.github/workflows/build_and_test.yml:
##########
@@ -856,7 +864,7 @@ jobs:
- name: Build with SBT
run: |
./dev/change-scala-version.sh 2.13
- ./build/sbt -Pyarn -Pmesos -Pkubernetes -Pvolcano -Phive -Phive-thriftserver -Phadoop-cloud -Pkinesis-asl -Pdocker-integration-tests -Pkubernetes-integration-tests -Pspark-ganglia-lgpl -Pscala-2.13 compile Test/compile
+ ./build/sbt -Pyarn -Pmesos -Pkubernetes -Pvolcano -Phive -Phive-thriftserver -Phadoop-cloud -Pkinesis-asl -Pdocker-integration-tests -Pkubernetes-integration-tests -Pspark-ganglia-lgpl -Pscala-2.13 compile Test/compile/ useCoursier := false
Review Comment:
And `useCoursier := false` should be configured in the `build.sbt` file rather than in the command line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42673: [SPARK-44959][BUILD] Upgrade sbt to 1.9.5
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42673:
URL: https://github.com/apache/spark/pull/42673#issuecomment-1733231969
```
1.Before run, delete all Maven's repos
```
Does this equate to removing the `Cache Maven local repository` step in lint?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42673: [SPARK-44959][BUILD] Upgrade sbt to 1.9.4
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42673:
URL: https://github.com/apache/spark/pull/42673#issuecomment-1693016607
no problem with the local build, I think you can try again. @panbingkun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42673: [SPARK-44959][BUILD] Upgrade sbt to 1.9.4
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42673:
URL: https://github.com/apache/spark/pull/42673#issuecomment-1694590528
Can we try to delete `~/.cache/coursier/v1/https` as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #42673: [SPARK-44959][BUILD] Upgrade sbt to 1.9.4
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42673:
URL: https://github.com/apache/spark/pull/42673#issuecomment-1719228795
> @panbingkun sbt 1.9.5 released: https://github.com/sbt/sbt/releases/tag/v1.9.5
>
> Can you reuse this ticket to verify it?
Okay, let me to verify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #42673: [SPARK-44959][BUILD] Upgrade sbt to 1.9.4
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42673:
URL: https://github.com/apache/spark/pull/42673#issuecomment-1698697172
> Gentle ping, @panbingkun . How do you want to proceed this?
@dongjoon-hyun
Let me think carefully, We may need to put workflow `scala-213` into the container run first, which is safer to delete some information, eg: `rm -rf /home/runner/.m2`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #42673: [SPARK-44959][BUILD] Upgrade sbt to 1.9.4
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #42673:
URL: https://github.com/apache/spark/pull/42673#discussion_r1306613214
##########
.github/workflows/build_and_test.yml:
##########
@@ -856,7 +864,7 @@ jobs:
- name: Build with SBT
run: |
./dev/change-scala-version.sh 2.13
- ./build/sbt -Pyarn -Pmesos -Pkubernetes -Pvolcano -Phive -Phive-thriftserver -Phadoop-cloud -Pkinesis-asl -Pdocker-integration-tests -Pkubernetes-integration-tests -Pspark-ganglia-lgpl -Pscala-2.13 compile Test/compile
+ ./build/sbt -Pyarn -Pmesos -Pkubernetes -Pvolcano -Phive -Phive-thriftserver -Phadoop-cloud -Pkinesis-asl -Pdocker-integration-tests -Pkubernetes-integration-tests -Pspark-ganglia-lgpl -Pscala-2.13 compile Test/compile/ useCoursier := false
Review Comment:
should be `-Dsbt.coursier=false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #42673: [SPARK-44959][BUILD] Upgrade sbt to 1.9.4
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42673:
URL: https://github.com/apache/spark/pull/42673#issuecomment-1693007802
> Scala 2.13 test seems to fail. Could you check it locally, @panbingkun ?
>
> 
Please do not merge in until I confirm. I will carefully check and it seems to be a cache issue at first glance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42673: [SPARK-44959][BUILD] Upgrade sbt to 1.9.4
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42673:
URL: https://github.com/apache/spark/pull/42673#issuecomment-1693936505
Oh, IIUC, although we cleared the cache, the last commit seems to show `Scala 2.13 SBT` failure still.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42673: [SPARK-44959][BUILD] Upgrade sbt to 1.9.5
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42673:
URL: https://github.com/apache/spark/pull/42673#issuecomment-1732962993
could you rebase this one ? @panbingkun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42673: [SPARK-44959][BUILD] Upgrade sbt to 1.9.5
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42673:
URL: https://github.com/apache/spark/pull/42673#issuecomment-1733235677
> Its root cause is that if there is a corrupted jar in Maven's repo
I'm curious about this conclusion, why didn't the use of Maven to build `java-other-versions` trigger similar issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #42673: [SPARK-44959][BUILD] Upgrade sbt to 1.9.4
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #42673:
URL: https://github.com/apache/spark/pull/42673#discussion_r1305423765
##########
.github/workflows/build_and_test.yml:
##########
@@ -237,7 +237,7 @@ jobs:
uses: actions/cache@v3
with:
path: ~/.cache/coursier
- key: ${{ matrix.java }}-${{ matrix.hadoop }}-coursier-${{ hashFiles('**/pom.xml', '**/plugins.sbt') }}
Review Comment:
only for test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42673: [SPARK-44959][BUILD] Upgrade sbt to 1.9.4
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42673:
URL: https://github.com/apache/spark/pull/42673#issuecomment-1718819441
@panbingkun sbt 1.9.5 released: https://github.com/sbt/sbt/releases/tag/v1.9.5
Can you reuse this ticket to verify it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44959][BUILD] Upgrade sbt to 1.9.5 [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42673:
URL: https://github.com/apache/spark/pull/42673#issuecomment-1876143930
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42673: [SPARK-44959][BUILD] Upgrade sbt to 1.9.5
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42673:
URL: https://github.com/apache/spark/pull/42673#issuecomment-1733038803
> > could you rebase this one ? @panbingkun
> > I have submitted a test on the latest master, but unfortunately it still has issues. I have identified the issue, but I need some time to see how to fix it reasonably.
> > https://github.com/panbingkun/spark/actions/runs/6294142093/job/17087611901
It appears that only lint-java downloads some jar files? Can we operate without using Maven cache? What would be the impact on performance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42673: [SPARK-44959][BUILD] Upgrade sbt to 1.9.4
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42673:
URL: https://github.com/apache/spark/pull/42673#issuecomment-1698567823
Gentle ping, @panbingkun . How do you want to proceed this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org