[GitHub] [arrow] alamb commented on pull request #8660: ARROW-10173: [Rust][DataFusion] Implement support for direct comparison to scalar values

[GitBox <gi...@apache.org>]

alamb commented on pull request #8660:
URL: https://github.com/apache/arrow/pull/8660#issuecomment-727205230


   I tried to run this code against our simple TPCH Q1 implementation (which is dominated by evaluating expressions against constants), and sadly it hit an error
   
   ```
   cd arrow/rust/benchmarks
   cargo run --release --bin tpch -- --iterations 3 --path /Users/alamb/Software/tpch_data/SF10-parquet-64 --format parquet --query 1 --batch-size 4096
       Finished release [optimized] target(s) in 0.13s
        Running `/Users/alamb/Software/arrow2/rust/target/release/tpch --iterations 3 --path /Users/alamb/Software/tpch_data/SF10-parquet-64 --format parquet --query 1 --batch-size 4096`
   Running benchmarks with the following options: TpchOpt { query: 1, debug: false, iterations: 3, concurrency: 2, batch_size: 4096, path: "/Users/alamb/Software/tpch_data/SF10-parquet-64", file_format: "parquet" }
   
   Error: ArrowError(ExternalError(General("Scalar values on left side of operator - are not supported")))
   ```
   
   I plan to figure out what is going on and try and fix it tomorrow morning, US Eastern time. As I said this I think this PR is a major step forward and I want to see it merged!
   
   Andrew
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org