[GitHub] [pinot] ankitsultana commented on a diff in pull request #8989: [colocated-join] Adds Table Group and Reusable Instance Partitions Support

[GitBox <gi...@apache.org>]

ankitsultana commented on code in PR #8989:
URL: https://github.com/apache/pinot/pull/8989#discussion_r933325312


##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/TableConfig.java:
##########
@@ -101,6 +102,9 @@ public class TableConfig extends BaseJsonConfig {
   @JsonPropertyDescription(value = "Configs for Table config tuner")
   private List<TunerConfig> _tunerConfigList;
 
+  @JsonPropertyDescription(value = "Name of the table-group")
+  private String _tableGroupName;

Review Comment:
   Based on our conversation, we went with creating a map in table-config called "instancePartitionsMap" which is from instance partitions type to an InstancePartitions name (could be a group or an existing table)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org