[GitHub] [dolphinscheduler] zhuangchong commented on a change in pull request #5782: [Improvement#5784][Task Instance List] And [UI]

[GitBox <gi...@apache.org>]

zhuangchong commented on a change in pull request #5782:
URL: https://github.com/apache/dolphinscheduler/pull/5782#discussion_r669501355



##########
File path: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
##########
@@ -699,8 +699,10 @@ private Constants() {
     /**
      * application regex
      */
-    public static final String APPLICATION_REGEX = "application_\\d+_\\d+";
+    /* public static final String APPLICATION_REGEX = "application_\\d+_\\d+"; */
+    public static final String APPLICATION_REGEX = "http[s]?://([\\w-]+\\.*)+[\\w-]+(/[\\w-.*/?%&=]*)?:(\\d*)/(\\w*)/application[_]?\\d+[_]?\\d+";

Review comment:
       
   
   
   I think the regular expression cannot be modified in this way. The yarn application id matching will involve tasks submitted by calculation engines such as flink, hive, spark, etc., and the printed yarn application id log formats are different. The following is the yarn application id printed by flink submitted tasks. , The modified regularity cannot be matched
   ```
   INFO  org.apache.flink.yarn.YarnClusterDescriptor                   - Found Web Interface xxxx of application 'application_1625147587008_396985'.
   
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org