[GitHub] [hive] scarlin-cloudera commented on a change in pull request #3084: HIVE-26015: URLEncode the URI for Ranger auth for HBase

[GitBox <gi...@apache.org>]

scarlin-cloudera commented on a change in pull request #3084:
URL: https://github.com/apache/hive/pull/3084#discussion_r823364267



##########
File path: hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java
##########
@@ -296,7 +297,8 @@ public URI getURIForAuth(Table table) throws URISyntaxException {
     String hbase_host = tableProperties.containsKey(HBASE_HOST_NAME)? tableProperties.get(HBASE_HOST_NAME) : hbaseConf.get(HBASE_HOST_NAME);
     String hbase_port = tableProperties.containsKey(HBASE_CLIENT_PORT)? tableProperties.get(HBASE_CLIENT_PORT) : hbaseConf.get(HBASE_CLIENT_PORT);
     String table_name = tableProperties.getOrDefault(HBaseSerDe.HBASE_TABLE_NAME, null);

Review comment:
       So I was thinking about doing it for the whole URI and not just the properties.
   I didn't research the characters that get URL Encoded versus the characters that are used in a table, but I was a bit nervous to URL Encode the table name which might break backward compatibility.  
   
   I figured URL encoding Serde properties was pretty safe though since it probably isn't used by Ranger.  I also thought about removing Serde properties from the URI, but that also had me worried about backward compatibility.
   
   I'm open to changing this or having more of a discussion on it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org