[GitHub] [trafficserver] ywkaras commented on a change in pull request #6996: Make the setting of the continuation handler safer.

[GitBox <gi...@apache.org>]

ywkaras commented on a change in pull request #6996:
URL: https://github.com/apache/trafficserver/pull/6996#discussion_r453661783



##########
File path: iocore/eventsystem/I_Continuation.h
##########
@@ -63,6 +63,26 @@ extern EThread *this_event_thread();
 
 typedef int (Continuation::*ContinuationHandler)(int event, void *data);
 
+// Convert event handler pointer fp to type ContinuationHandler, but with a compiler error if class C is not
+// derived from the class Continuation.

Review comment:
       It is a constexpr function, it will be evaluated at compile time, and cause no additional instructions in the executable.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org